Allow web-based payment handlers to report back internal error#429
Open
stephenmcgruer wants to merge 4 commits intogh-pagesfrom
Open
Allow web-based payment handlers to report back internal error#429stephenmcgruer wants to merge 4 commits intogh-pagesfrom
stephenmcgruer wants to merge 4 commits intogh-pagesfrom
Conversation
romandev
reviewed
Mar 5, 2026
| </li> | ||
| <li>If <var>handlerResponse</var>.<a data-lt= | ||
| "PaymentHandlerResponse.details">details</a> is not present | ||
| or not <a>JSON-serializable</a>, run the <a>payment app |
Member
There was a problem hiding this comment.
I noticed that the details validation step doesn't pass an OperationError DOMException to the payment app failure algorithm, while the other validation steps (e.g., methodName, shippingAddress, payerName, etc.) all do.
Was this intentional, or just accidentally missed? Let me know if there's a reason for treating it differently — I might be missing some context.
Collaborator
Author
There was a problem hiding this comment.
Nope, oversight! Fixed.
ianbjacobs
approved these changes
Mar 20, 2026
Collaborator
Author
|
Thanks both for the reviews! I need to update the WPTs still, so this is pending that. Just need to find the time 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #428 and w3c/payment-request#1040
closes #???
The following tasks have been completed:
Implementation commitment:
Preview | Diff