Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Add the run tests in iframe feature.#33

Open
xiuqijix wants to merge 4 commits into
w3c:masterfrom
xiuqijix:xiuqi/iframe
Open

Add the run tests in iframe feature.#33
xiuqijix wants to merge 4 commits into
w3c:masterfrom
xiuqijix:xiuqi/iframe

Conversation

@xiuqijix

@xiuqijix xiuqijix commented Sep 6, 2015

Copy link
Copy Markdown

This change is Reviewable

@hoppipolla-critic-bot

Copy link
Copy Markdown

Critic review: https://critic.hoppipolla.co.uk/r/5789

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@xiuqijix xiuqijix changed the title Xiuqi/iframe Add the run tests in iframe feature. Sep 6, 2015
@xiuqijix

xiuqijix commented Sep 6, 2015

Copy link
Copy Markdown
Author

Add a feature that run tests in iframe by select "Run Tests in "iframe"" checkbox.

@jgraham

jgraham commented Nov 30, 2015

Copy link
Copy Markdown
Member

Just the top patch here has a handful of trivial issues (see critic) and I would like to merge it if you fix those.

@yugang

yugang commented Dec 2, 2015

Copy link
Copy Markdown

@jgraham , the first two commits have the same reason here: #31, we just need merge the last one of the four commits.

@xiuqijix

xiuqijix commented Dec 8, 2015

Copy link
Copy Markdown
Author

@jgraham , the first three commits have the same reason here: #32 .You can merge #33 after #32 , thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants