-
Notifications
You must be signed in to change notification settings - Fork 17
Batch ring proof #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Batch ring proof #64
Conversation
|
For
|
|
TODO:
|
|
Single proof (
|
|
so this is a for a single ring isn't it? it doesn't batch for different rings. Could batching for multiple rings also be improved (I mean in general, not necessarily in this PR). could we also benchmark for 1000 and 10000 just to see the limit of improvement? |
This is todo item #5.
Kinda. I'll need to generate 1k different proofs (from scratch, as plonk doesn't support proof randomization) for that, that takes some time. |
| pub fn new(kzg_vk: KzgVerifierKey<E>) -> Self { | ||
| //TODO: capacity | ||
| Self { | ||
| acc_points: vec![kzg_vk.g1], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires g1 to be public
|
Needs some changes to KZG in fflonk (private fields and a couple of missing Clone bounds) |
a353856 to
5eff645
Compare
|
NOTE: I accidentally pushed here, but I have reverted to your changes. That is why you see a force push. |
|
@swasilyev BatchVerifier struct : #66 ark-vrf integration draft: davxy/ark-vrf#67 |
ATM twice faster for the batch of 10