Skip to content

Add resume session button - #55

Merged
flee135 merged 4 commits into
wafo:masterfrom
flee135:resume-session
Jun 26, 2026
Merged

Add resume session button#55
flee135 merged 4 commits into
wafo:masterfrom
flee135:resume-session

Conversation

@flee135

@flee135 flee135 commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Adds a resume session button to the launcher. This allows users to close their tracker, and then pick up where they left off later. This includes items, dungeon rewards, reward labels, songs, keys, and completed checks. If random dungeon shortcuts or random MQ dungeons are turned on, it will also remember which dungeons were toggled as having shortcuts or MQ.

A new HINT_ENTRY reducer case is added to save text typed into hint boxes, including paths, barrens, and sometimes.

Dragged icons required a bit more work to support. On opening the launcher, icons are mapped to blob URLs, and these are not consistent whenever the launcher is opened. We already map icon name -> URL, so we create the inverse URL -> name map, and expose both to the tracker context. When icons are dragged, we save the names, and when resuming a session, we translate the names back to the current session's blob URLs.

The boss boxes in path hints use the same flow as clicking the receivers, but they aren't tagged as receivers, so they're given a new persistIcon property so we know to save those icons.

Resuming a session will force the current layout, generator version, and settings string back to the saved ones.

image

@tanjo3 tanjo3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through, tested it, seems good to me. The hints not being saved is a bit unexpected so it should probably be noted somewhere so a user knows to saved their hints elsewhere. You should probably increment the minor version number too.

I had Claude review the PR as well and it picked up a few things for robustness, but I didn't flag them here as these changes are fine without them. If we wanted to, it'd probably best to review the entire codebase for robustness/security as its own PR.

@flee135

flee135 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Looked through, tested it, seems good to me. The hints not being saved is a bit unexpected so it should probably be noted somewhere so a user knows to saved their hints elsewhere. You should probably increment the minor version number too.

I had Claude review the PR as well and it picked up a few things for robustness, but I didn't flag them here as these changes are fine without them. If we wanted to, it'd probably best to review the entire codebase for robustness/security as its own PR.

Thanks! I'll spend a bit of time looking into saving hints since that really would be a huge convenience to have. If it looks to be a nuisance I'll leave it out of this PR.

Also FYI, I noticed the original PR description was out of date. It said layout, generator version, and settings string had to match the saved one, but I've since updated it to force it back to the saved ones.

@flee135
flee135 requested a review from tanjo3 June 25, 2026 07:09
@flee135

flee135 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

I think I've covered everything persisting between sessions. Lmk if it behaves as you'd expect.

@tanjo3 tanjo3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, seems to work as expected.

@flee135
flee135 merged commit a95f0a5 into wafo:master Jun 26, 2026
1 check passed
@flee135
flee135 deleted the resume-session branch July 2, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants