Improve tooltips - #60
Merged
Merged
Conversation
flee135
reviewed
Jul 24, 2026
flee135
left a comment
Collaborator
There was a problem hiding this comment.
LG overall, just the one consideration that we discussed briefly offline about how we show songs in tooltips.
Results in ~25% speedup when building the region cache
`expandDrop`/`expandEvent` previously ran entirely outside the memo window. Results in ~200ms improvement per evaluation.
…site e.g., Deku_Stick_Drop resolves as an identifier, a path that had no guard. Fairy resolves as an literal, which was guarded. Now, both paths are guarded. Improved consistency and ~30 ms performace gain.
…ments Affects King Dodongo, Volvagia, Bongo Bongo, and Twinrova with dungeon shortcuts enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to improve/correct item tooltips:
has_all_notes_for_song,region_has_shortcuts, bombchu bags, and other previously-unsupported settings. Should fix the logic for the SAWS tooltips.