Check tracking launcher fixes - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching without check tracking was broken. This had to do with setting 9.1.0 as the current active version, but only having 9.0.0 actually bundled. When trying to resolve the settings string, it falls back to settingsDefault for the bundle, which is undefined.
Doing logic initialization when check tracking is off was introduced with the 9.0 refactor and seems to be a bug, so any logic initialization is removed here. Resume session is also modified so that restoring state related to checks is only done when the session included check tracking.
For good measure, a check is added so that if the user attempts to launch the tracker without the settings string, it doesn't attempt to use a default string and silently keep working with a string that the user might not expect. Instead, a warning is shown and the tracker will not launch.