qualcomm ai100 docker support#11
Conversation
seanshahkarami
left a comment
There was a problem hiding this comment.
Hello! Just starting to look at this PR now.
I noticed that a number of script have their mode changed from 755 to 644. Was this a mistake?
I'm concerned that this will have some downstream effects on services which may rely on this.
|
When running Is there a step I should do before this? It doesn't seem like anything is mentioned in the docs about where to get this? Is it ok if it's empty when leaving out the |
|
Really minor detail - we should figure out a different way to select the build platform since many people will probably expect |
|
@hpeliuhan Just wanted to bring up the comments above again, specifically this one.
Unfortunately, changing some of the key scripts to be non-executable will likely break things and I'd like to fix that before merging. We can probably skip the other ones for now and fix that in a later PR. |
No description provided.