fix: make API URL configurable + add timeout + proper error handling (fixes #5)#6
Open
D2758695161 wants to merge 1 commit into
Open
fix: make API URL configurable + add timeout + proper error handling (fixes #5)#6D2758695161 wants to merge 1 commit into
D2758695161 wants to merge 1 commit into
Conversation
Fixes wangtsiao#5 - Fetch Failed error Changes: - API base URL now configurable via VVHAN_API_URL env var - Added fetch timeout (default 8s, configurable via VVHAN_TIMEOUT_MS) - Better error messages for debugging - Falls back gracefully on network errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes wangtsiao/pulse-cn-mcp#5 — "Fetch Failed"
Problem
When
api.vvhan.comis inaccessible or slow, all tools fail with unhelpful error messages. The hardcoded API URL provides no way to use alternative endpoints.Solution
Configurable API URL via
VVHAN_API_URLenvironment variable:Fetch timeout (default 8s, configurable via
VVHAN_TIMEOUT_MS):Better error messages for debugging:
Files changed
src/utils/fetch.ts— core fetch utilityTesting