Skip to content

Add agent CLI flag for cloud runs#9935

Open
bnavetta wants to merge 2 commits intomasterfrom
ben/add-run-cloud-agent-flag
Open

Add agent CLI flag for cloud runs#9935
bnavetta wants to merge 2 commits intomasterfrom
ben/add-run-cloud-agent-flag

Conversation

@bnavetta
Copy link
Copy Markdown
Contributor

@bnavetta bnavetta commented May 2, 2026

Summary

  • Adds --agent <UID> to warp agent run-cloud.
  • Sends the value as agent_identity_uid, matching the public agent run API request field.
  • Updates spawn request construction sites and tests for CLI parsing and request serialization.

Testing

  • git --no-pager diff --check
  • cargo nextest run --manifest-path /workspace/warp/Cargo.toml -p warp_cli agent_run_cloud_accepts_agent_flag
  • CARGO_BUILD_JOBS=1 cargo check --manifest-path /workspace/warp/Cargo.toml -p warp --lib
  • CARGO_BUILD_JOBS=1 cargo nextest run --manifest-path /workspace/warp/Cargo.toml -p warp spawn_agent_request_serializes_agent_uid_as_agent_identity_uid
  • Not run: cargo fmt --manifest-path /workspace/warp/Cargo.toml --all --check (rustfmt is not installed in the sandbox toolchain)

Co-Authored-By: Oz oz-agent@warp.dev

Conversation: https://staging.warp.dev/conversation/e3cb2fc1-34d8-43cf-b8cd-fd894946656a
Run: https://oz.staging.warp.dev/runs/019dea24-d12b-719f-9ba4-bb9435d546df
This PR was generated with Oz.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label May 2, 2026
@bnavetta bnavetta changed the title Add agent UID flag for cloud runs Add agent CLI flag for cloud runs May 2, 2026
@bnavetta bnavetta marked this pull request as ready for review May 2, 2026 20:52
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 2, 2026

@bnavetta

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@bnavetta bnavetta requested a review from ianhodge May 2, 2026 20:53
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a --agent <UID> option to warp agent run-cloud, carries it through the ambient-agent spawn request as agent_identity_uid, and updates request construction sites plus focused CLI/serialization tests.

Concerns

  • No blocking correctness or security concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants