Open
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR adds a --agent <UID> option to warp agent run-cloud, carries it through the ambient-agent spawn request as agent_identity_uid, and updates request construction sites plus focused CLI/serialization tests.
Concerns
- No blocking correctness or security concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
ianhodge
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--agent <UID>towarp agent run-cloud.agent_identity_uid, matching the public agent run API request field.Testing
git --no-pager diff --checkcargo nextest run --manifest-path /workspace/warp/Cargo.toml -p warp_cli agent_run_cloud_accepts_agent_flagCARGO_BUILD_JOBS=1 cargo check --manifest-path /workspace/warp/Cargo.toml -p warp --libCARGO_BUILD_JOBS=1 cargo nextest run --manifest-path /workspace/warp/Cargo.toml -p warp spawn_agent_request_serializes_agent_uid_as_agent_identity_uidcargo fmt --manifest-path /workspace/warp/Cargo.toml --all --check(rustfmtis not installed in the sandbox toolchain)Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/e3cb2fc1-34d8-43cf-b8cd-fd894946656a
Run: https://oz.staging.warp.dev/runs/019dea24-d12b-719f-9ba4-bb9435d546df
This PR was generated with Oz.