fix(shared-session): hide "Copy session sharing link" when no link exists (GH9736)

[gulsahsarsilmaz]

Description

Fixes #9736. The right-click Copy session sharing link menu item was offered whenever the session's SharedSessionStatus was anything other than NotShared. That set includes the pending states (SharePending, SharePendingPreBootstrap) and the post-end FinishedViewer state — none of which have an actual sharing URL. After a session fails to share (the reproduction described in #9735), the status remains in SharePending* and the menu still offers the copy entry; selecting it writes a stale or empty value to the clipboard.

Fix

Introduce a new predicate SharedSessionStatus::has_active_share_link() that returns true only for ActiveSharer and ActiveViewer { .. } and use it to gate the menu entry in session_sharing_context_menu_items (app/src/terminal/view/shared_session/view_impl.rs:1633):

pub fn has_active_share_link(&self) -> bool {
    matches!(self, Self::ActiveSharer | Self::ActiveViewer { .. })
}

Pending and finished states no longer surface the copy entry, so a session that failed to share simply leaves the right-click menu showing only the unrelated entries (Share session... / Stop sharing) — which matches the expected behavior in #9736 ("I should not be offered to duplicate a non-existent URI into my clipboard").

What is not changed

The existing is_sharer_or_viewer helper is kept unchanged because other call sites — most notably the reconnection-banner guard at app/src/terminal/view/shared_session/view_impl.rs:1571–1582 — intentionally include pending states. Adding a separate, narrower predicate (rather than tightening the existing one) avoids touching those sites.

#9735 (the underlying "share fails" reproduction) is a separate root-cause that is out of scope for this PR; this change makes the secondary symptom (stale menu entry) safe regardless of whether #9735 is fixed.

Linked Issue

Closes #9736.

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

No new visual UI is added; the change hides an existing menu entry in states where it should not appear. The reproduction video on the linked issue (the menu showing Copy session sharing link after a failed share) demonstrates the pre-fix behavior; with this PR the entry is absent in that state.

Testing

Regression test added in app/src/terminal/shared_session/mod_test.rs (has_active_share_link_only_true_for_active_states). It asserts:

• ActiveSharer and both ActiveViewer role variants (Reader, Executor) return true.
• NotShared, SharePending, SharePendingPreBootstrap, ViewPending, and FinishedViewer all return false.

The SharePendingPreBootstrap assertion is the one that pins the GH#9736 regression specifically — that's the state a failed-to-share session sits in.

Manual verification on macOS (SharedSession flows): right-click during a SharePending session shows only Stop sharing (no Copy session sharing link); after the share fully establishes (ActiveSharer), the entry returns. After Stop sharing, the menu reverts to Share session... only.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

[oz-for-oss]

@gulsahsarsilmaz

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR adds a narrower SharedSessionStatus::has_active_share_link() predicate, uses it to hide the right-click copy-link entry when no active share link exists, and adds unit coverage for the status mapping.

Concerns

• ⚠️ The same CopySharedSessionLink action is still exposed from the pane header overflow menu in app/src/terminal/view/pane_impl.rs, where Copy link is gated by is_sharer_or_viewer(). Pending, failed, or finished shared-session states can still present a copy-link entry through that surface, so apply the new active-link predicate there too or document why that menu should differ.
• For faster review, please upload screenshots or a video of the context menu behavior working end to end. This is a user-visible change because an existing menu item disappears in pending/failed states.

Verdict

Found: 0 critical, 1 important, 1 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[gulsahsarsilmaz]

Thanks for the catch @oz-for-oss. v2 pushed (f8d949c).

Pane-header overflow menu fixed

app/src/terminal/view/pane_impl.rs:654 had the same is_sharer_or_viewer() gate over a block containing Copy link, Stop sharing session, and Open on Desktop. Naïvely tightening the outer condition would have also hidden Stop sharing session during pending states — but a user with a stuck/failed share needs that entry to clean up. So I scoped the change narrower: only the inner Copy link push is moved under has_active_share_link(), the neighbouring entries stay under the broader checks.

if shared_session_status.is_sharer_or_viewer() {
    if !is_ambient_agent && shared_session_status.has_active_share_link() {
        items.push(MenuItemFields::new("Copy link") ... );
    }
    if shared_session_status.is_sharer() {
        items.push(MenuItemFields::new("Stop sharing session") ... );  // unchanged
    }
    // ... Open on Desktop also unchanged for the same reason
}

If Open on Desktop has the same stale-state issue (it dispatches OpenSharedSessionOnDesktop which presumably also resolves to a URL) that's worth a separate follow-up issue — it's a behavioural question whether the desktop deep-link should be offered during pending states, distinct from the clipboard-copy concern.

Screenshot / video

I can't capture the menu interactively from this environment. The reproduction video on #9736 already shows the pre-fix behavior (the entry appearing after a failed share). After this PR both menu surfaces no longer offer the copy entry in SharePending, SharePendingPreBootstrap, or FinishedViewer states, while Stop sharing session continues to be offered so failed/stuck shares are still cancellable. If a maintainer with a Warp dev build wants to attach a confirmation screencast I'd appreciate it; otherwise the regression test pins the slot-level invariant.

/oz-review

[oz-for-oss]

@gulsahsarsilmaz

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR adds SharedSessionStatus::has_active_share_link() and uses it to hide copy-link menu items until a shared session has an active sharer/viewer link. The regression test covers the active states and pending/finished states relevant to GH#9736.

Concerns

• This changes user-visible menu behavior, but the PR description does not include attached post-fix screenshots or a video showing the right-click menu in the pending/failed state and again after the link is active. For faster review, please upload screenshots or a video of the feature working end to end.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz