Fix queue mode not respected for code review comments#9961
Fix queue mode not respected for code review comments#9961ssgamingop wants to merge 5 commits intowarpdotdev:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @ssgamingop on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds queue-mode routing for submitted code review comments and introduces a structured queued-input path for AIAgentInput::CodeReview.
Concerns
- Queued code review inputs are preserved on successful completion, but the cancellation/error fallback restores only the generic display prompt and drops the review comment batch.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
I've pushed some follow-up changes to harden the queuing logic. This ensures that structured review comments aren't lost if a conversation is interrupted or fails, and standardizes the cancellation flow. Ready for re-review!" |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds queue-mode handling for code review submissions by routing structured review inputs through the queued AI prompt path and exposing queue detection to the routing layer.
Concerns
- Queued structured code review inputs are not recoverable if the active conversation errors or is cancelled before the queued input is sent; only the display prompt is restored, while the review comments and diff context are dropped.
- Security pass: no security-specific findings.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| | FinishReason::CancelledDuringRequestedCommandExecution => { | ||
| terminal_view.input.update(ctx, |input, ctx| { | ||
| if input.buffer_text(ctx).is_empty() { | ||
| input.replace_buffer_content(&prompt, ctx); |
There was a problem hiding this comment.
ai_input.user_query() (for code reviews, Address these comments) and drops the review batch/diff context when the active conversation is cancelled or errors, so queued review comments can be lost instead of recoverable. Preserve the structured input or keep the pending review available for resubmission.
1 participant
Problem
Queue mode is not respected when code review comments are submitted
to an agent that already has a task in progress. Instead of creating
a queued code review action, submitted review comments are sent
immediately and appear to adjust the currently running task.
Solution
Added queue mode awareness to the code review routing logic:
should_queue_inline_review()public for use in routing layerroute_review_comments()to check queue mode before routingsend_inline_review()when queueing appliesChanges
app/src/terminal/view.rs- Madeshould_queue_inline_review()publicapp/src/workspace/view/right_panel.rs- Added queue mode check in routingTesting
Related Issues