Skip to content

feat: add "Restore macOS Terminal as Default" functionality#9971

Open
jiakeboge wants to merge 2 commits intowarpdotdev:masterfrom
jiakeboge:feature/unset-default-terminal
Open

feat: add "Restore macOS Terminal as Default" functionality#9971
jiakeboge wants to merge 2 commits intowarpdotdev:masterfrom
jiakeboge:feature/unset-default-terminal

Conversation

@jiakeboge
Copy link
Copy Markdown

Description

This PR implements the functionality to unset Warp as the default terminal. Currently, setting Warp as the default terminal is a one-way operation. This change allows users to easily revert the default terminal setting back to the macOS system Terminal (com.apple.Terminal).

The implementation includes:

  • A new platform-specific function for macOS to restore the default role handler to Terminal.app.
  • A dynamic menu item that toggles between "Set Warp as Default Terminal" and "Restore macOS Terminal as Default" based on the current state.
  • An updated Features settings page that provides a link to restore the default terminal when Warp is currently set as default.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Screenshots or a short video of the implementation are included below.

Screenshots / Videos

  • [Menu Bar Toggle Demonstration]
  • [Settings Page Link Update]

Testing

  • Manual Testing: Verified on macOS that clicking "Set Warp as Default Terminal" correctly updates the system setting, and the menu item subsequently changes to "Restore macOS Terminal as Default". Clicking the restore option correctly sets the default back to Terminal.app.
  • Unit Testing: Updated the DefaultTerminal model to ensure the is_warp_default state is correctly updated when the restore action is triggered.
  • Cross-platform: Verified that the logic correctly fallbacks to "Not implemented" on non-macOS platforms.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Changelog Entries for Stable

CHANGELOG-IMPROVEMENT: Added the ability to restore the macOS system Terminal as the default terminal from the Warp menu and settings page.

jiakeboge added 2 commits May 3, 2026 18:38
This change allows users to revert the default terminal setting back to
the macOS system Terminal (com.apple.Terminal).
- Added `unset_warp_as_default_terminal` to macOS platform implementation.
- Updated `DefaultTerminal` model to support unsetting the default status.
- Modified the app menu to dynamically toggle between "Set" and "Unset" labels.
- Enabled unsetting the default terminal from the Features settings page.
 - Added `unset_warp_as_default_terminal` to revert to Terminal.app.
 - Updated menu item label to "Restore macOS Terminal as Default" when Warp is the current default.
 - Added a corresponding link in the Features settings page for better discoverability.
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 3, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jiakeboge on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 3, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 3, 2026

@jiakeboge

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @lucieleblanc.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a macOS restore path for the default terminal handler, updates the app menu to toggle between setting Warp and restoring Terminal.app, and adds a matching settings-page action.

Concerns

No important correctness or security concerns were identified in the changed diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from lucieleblanc May 3, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant