feat: add "Restore macOS Terminal as Default" functionality#9971
feat: add "Restore macOS Terminal as Default" functionality#9971jiakeboge wants to merge 2 commits intowarpdotdev:masterfrom
Conversation
This change allows users to revert the default terminal setting back to the macOS system Terminal (com.apple.Terminal). - Added `unset_warp_as_default_terminal` to macOS platform implementation. - Updated `DefaultTerminal` model to support unsetting the default status. - Modified the app menu to dynamically toggle between "Set" and "Unset" labels. - Enabled unsetting the default terminal from the Features settings page.
- Added `unset_warp_as_default_terminal` to revert to Terminal.app. - Updated menu item label to "Restore macOS Terminal as Default" when Warp is the current default. - Added a corresponding link in the Features settings page for better discoverability.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jiakeboge on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @lucieleblanc. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a macOS restore path for the default terminal handler, updates the app menu to toggle between setting Warp and restoring Terminal.app, and adds a matching settings-page action.
Concerns
No important correctness or security concerns were identified in the changed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
This PR implements the functionality to unset Warp as the default terminal. Currently, setting Warp as the default terminal is a one-way operation. This change allows users to easily revert the default terminal setting back to the macOS system Terminal (
com.apple.Terminal).The implementation includes:
Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
Testing
DefaultTerminalmodel to ensure theis_warp_defaultstate is correctly updated when the restore action is triggered.Agent Mode
Changelog Entries for Stable
CHANGELOG-IMPROVEMENT: Added the ability to restore the macOS system Terminal as the default terminal from the Warp menu and settings page.