Fix cloud status badge using themed background instead of white#9976
Fix cloud status badge using themed background instead of white#9976harryalbert wants to merge 1 commit intomasterfrom
Conversation
harryalbert
force-pushed
the
oz-agent/fix-cloud-status-badge-color
branch
from
9bae0c3 to
6f55505
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
The cloud overlay in the icon-with-status component was hardcoded to ColorU::white(), making themed status icon colors (e.g. ansi_fg_green for success) nearly invisible in dark mode. Use badge_ring_background for the cloud fill instead, mirroring how the non-cloud status badge uses the same surface color for its cutout ring. Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
force-pushed
the
oz-agent/fix-cloud-status-badge-color
branch
from
6f55505 to
a8220f8
Compare
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the shared icon-with-status helper so ambient/cloud status badges use the caller-provided themed status container background instead of a hard-coded white cloud, while keeping the non-cloud status badge on the same fill source.
Concerns
No blocking correctness or security concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Description
The cloud status container should use the same themed background as the regular status container (confirmed from Peter's original figma that this was always the intention)
Linked Issue
Fixes APP-4369
Testing
Agent Mode
Conversation: https://staging.warp.dev/conversation/ebc3b299-10da-4229-8024-2bb3a6e6a9b9
Run: https://oz.staging.warp.dev/runs/019dee41-47db-7eb2-b477-1bdd26d8f2b3
This PR was generated with Oz.