Skip to content

fix(windows): unblock release build on MSVC 14.51 coroutine hard error #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ByYudkowskysTentacle wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −3
Open

fix(windows): unblock release build on MSVC 14.51 coroutine hard error #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1861cc4
fix(windows): unblock release build on MSVC 14.51 coroutine hard error
claude Aug 25, 2026
366ac00
Merge pull request #1 from ByYudkowskysTentacle/claude/windows-releas…
ByYudkowskysTentacle Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,10 @@ jobs:
[Files]
Source: "build\windows\x64\runner\Release\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs
[Icons]
Name: "{group}\OpenLibExtended"; Filename: "{app}\OpenLibExtended.exe"
Name: "{autodesktop}\OpenLibExtended"; Filename: "{app}\OpenLibExtended.exe"
Name: "{group}\OpenLibExtended"; Filename: "{app}\OpenlibExtended.exe"
Name: "{autodesktop}\OpenLibExtended"; Filename: "{app}\OpenlibExtended.exe"
[Run]
Filename: "{app}\OpenLibExtended.exe"; Description: "Launch OpenLibExtended"; Flags: nowait postinstall skipifsilent
Filename: "{app}\OpenlibExtended.exe"; Description: "Launch OpenLibExtended"; Flags: nowait postinstall skipifsilent
"@ | Out-File -FilePath "installer.iss" -Encoding UTF8
mkdir artifacts
& "C:\Program Files (x86)\Inno Setup 6\ISCC.exe" installer.iss
Expand Down
10 changes: 10 additions & 0 deletions windows/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@ set(CMAKE_CXX_FLAGS_PROFILE "${CMAKE_CXX_FLAGS_RELEASE}")
# Use Unicode for all projects.
add_definitions(-DUNICODE -D_UNICODE)

# MSVC 14.51 (Visual Studio 2026) promoted the <experimental/coroutine>
# deprecation to a hard error (STL1011). Two plugins still reach that header
# through C++/WinRT: flutter_inappwebview_windows compiles as C++17, so
# <winrt/base.h> falls back to the experimental header, and
# permission_handler_windows builds with /await, which selects the experimental
# coroutine machinery outright. Both are regenerated under
# flutter/ephemeral/.plugin_symlinks by `flutter pub get`, so the opt-out is set
# here, ahead of the plugin subdirectories below, to reach every plugin target.
add_definitions(-D_SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGS)

# Compilation settings that should be applied to most targets.
#
# Be cautious about adding new options here, as plugins use this function by
Expand Down