use smithy-bindgen to gen interface, re-export as 'testing'#24
Merged
Conversation
Signed-off-by: stevelr <steve@cosmonic.com>
rvolosatovs
reviewed
Feb 20, 2023
rvolosatovs
reviewed
Feb 20, 2023
rvolosatovs
reviewed
Feb 20, 2023
rvolosatovs
reviewed
Feb 20, 2023
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Contributor
Author
|
Dependent on wasmCloud/weld#143 |
Contributor
Author
|
Other than the references in Cargo.toml (which are blocked on other prs), this is ready for review |
rvolosatovs
reviewed
Feb 27, 2023
Co-authored-by: Roman Volosatovs <rvolosatovs@users.noreply.github.com>
Contributor
Author
|
This uses the new smithy-bindgen crate and the latest wasmbus-rpc. Bumped version to 0.7.0 since we now recommend that instead of importing wasmcloud-interface-testing, clients of this crate |
Member
Signed-off-by: stevelr <steve@cosmonic.com>
thomastaylor312
previously requested changes
Feb 28, 2023
Contributor
thomastaylor312
left a comment
thomastaylor312
left a comment
There was a problem hiding this comment.
Minor changes and a nit that is totally optional
stevelr
requested review from
thomastaylor312
and removed request for
rvolosatovs
Member
brooksmtownsend
left a comment
brooksmtownsend
left a comment
There was a problem hiding this comment.
I'm good with this as long as @thomastaylor312 is 😄
Signed-off-by: stevelr <steve@cosmonic.com>
Contributor
Author
|
@thomastaylor312 addressed your concern with 077dae2 |
brooksmtownsend
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Problem
testingRelated Issues
Waiting on wasmCloud/weld#143
Release Information
Consumer Impact
Acceptance or Integration
Manual Verification
Still testing w/ other crates