Change nlohmann_json to nlohmann-json-dev#29
Merged
Conversation
This allows the nlohmann json library dependency to be installed with rosdep, and the ros2.repos file can be deleted.
evan-palmer
approved these changes
May 29, 2026
Contributor
|
Nice! I wasn't aware of this package |
Contributor
Author
|
@wlkh Can you please review this? |
wlkh
approved these changes
Jun 4, 2026
wlkh
left a comment
wlkh
left a comment
Collaborator
There was a problem hiding this comment.
Great! Thanks for the fix 👍
Collaborator
|
@evan-palmer The pipeline fails in main after merging. Do you have an idea/thoughts of why this worked in the PR but fails in main? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the nlohmann json library dependency to be installed with rosdep, and the ros2.repos file can be deleted.
Changes Made
Renamed the
nlohmann_jsonrosdep dependency in libwaterlinked tonlohmann-json-dev(which rosdep can resolve and install). This way, downstream users of this library don't need to use--skip-keys nlohmann_jsonon every build.