Skip to content

chore(guard): sync vendored public-repo-guard to canonical - #80

Open
wave-av-release-bot[bot] wants to merge 2 commits into
mainfrom
chore/guard-canonical-sync
Open

chore(guard): sync vendored public-repo-guard to canonical#80
wave-av-release-bot[bot] wants to merge 2 commits into
mainfrom
chore/guard-canonical-sync

Conversation

@wave-av-release-bot

@wave-av-release-bot wave-av-release-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

Syncs the vendored public-repo-guard trio to the canonical source in wave-foundation/scaffolder/public-repo-guard.

  • adds the internal-ip leak rule (Tailscale-CGNAT 100.64.0.0/10), lockstep with the pre-publish mirror gate
  • reconciles accumulated drift in the vendored copy

Each changed file is byte-for-byte identical to canonical (verified by git blob SHA). The repo's own Secrets + content policy gate re-scans this PR.

🤖 Generated with Claude Code


Open in Devin Review

Note

Update public-repo-guard workflow to use actions/checkout v7 without persisted credentials

Syncs public-repo-guard.yml to the canonical version. Upgrades actions/checkout from v5.0.1 to v7.0.0 and sets persist-credentials: false so the GITHUB_TOKEN is no longer stored in the repository's Git config after checkout.

Macroscope summarized 0699010.


Summary by cubic

Synced the vendored public-repo-guard to wave-foundation/scaffolder/public-repo-guard and added an internal IP leak rule for 100.64.0.0/10 (Tailscale CGNAT). Hardened the guard workflow by upgrading to actions/checkout v7.0.1 and disabling persisted credentials for scans.

  • Refactors
    • Reconciled drift; files now match canonical byte-for-byte.
    • Set persist-credentials: false for actions/checkout since scans run --no-git and need no Git auth; the comment documents why the token is dropped.

Written for commit 4d3aa34. Summary will update on new commits.

Review in cubic

Summary by Sourcery

Synchronize the vendored repository guard with its canonical source and strengthen its workflow credential handling.

New Features:

  • Add detection for internal IP leaks in the Tailscale CGNAT range (100.64.0.0/10).

Enhancements:

  • Synchronize the vendored public-repo-guard files with the canonical source.
  • Harden the repository guard workflow by disabling persisted checkout credentials.

CI:

  • Update the repository guard workflow to the canonical checkout configuration.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR author is in the excluded authors list.

@macroscopeapp

macroscopeapp Bot commented Aug 4, 2026

Copy link
Copy Markdown

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The base-to-head diff only revises comments; the workflow behavior and credential setting are unchanged, and the supplied review comment found no defect. Human review is still recommended because the sole changed file is an explicitly core-team-owned workflow path not owned by the release bot.

Not approved because:

  • Credit balance exhausted. Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

# downloads a third-party binary (gitleaks, below) and runs it over the whole
# tree. Nothing here pushes -- the scan is `--no-git` over the working tree --
# so no step needs authenticated Git; drop it. (zizmor: artipacked)
persist-credentials: false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 persist-credentials: false is safe for this job's steps

Verified that no step in this job performs an authenticated git operation: gitleaks runs with --no-git --source . over the working tree (line 65), and content-policy.sh is invoked on the checkout directory only. Disabling credential persistence therefore does not break the scan. Worth confirming scripts/public-repo-guard/content-policy.sh never shells out to git fetch/git log against the remote, which would now fail for private-repo contexts.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Both sides pinned actions/checkout with persist-credentials: false. Kept
main newer SHA (3d3c42e5, verified against the upstream v7.0.1 tag) and
this branch fuller rationale comment for why the job drops the token.
@codeant-ai

codeant-ai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Skipping PR review because a bot author is detected.

If you want to trigger CodeAnt AI, comment @codeant-ai review to trigger a manual review.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant