chore(facts): waive a disclosure false positive on the troubleshooting env-var reference - #83
chore(facts): waive a disclosure false positive on the troubleshooting env-var reference#83yakimoto wants to merge 3 commits into
Conversation
…g env-var reference The new disclosure gate (wave-av/wave-context#157) flags an env-var name near a state verb, because that pattern is how deployed configuration state leaks into published content. Here it is a false positive worth recording rather than silencing: the README's troubleshooting section tells the READER to check their OWN environment, so the variable belongs to the person installing the MCP server and says nothing about any WAVE deployment. Waivers are scoped to rule AND match together, so this excuses exactly this identifier and cannot quietly cover a genuine deployed value added later. The finding stays printed on every run - only the exit code ignores it. Unrelated and NOT addressed here: this repo already fails the policy gate on a pre-existing disallowed-url finding (an npm link outside the @wave-av scope), which predates this change.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7972715e-2a59-4988-a6f4-a4a35461e615) |
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 97 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
PR Summary by QodoWaive disclosure gate false positive for README troubleshooting env var
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR only changes repository metadata and scanning waivers, but the npm URL waiver covers every package under the Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…isting npm link Two additions beyond the original disclosure waiver on this branch: 1. `description` declared in the SSOT. The live GitHub description claimed "19 tools"; the resolver-backed claim in this same file says 18, and the claim is the grounded number. The live description has been corrected to 18 and is now declared here, so the description drift gate compares against a checked value instead of unreviewed marketing copy. 2. `policyWaivers` entry for the @Anthropic-AI npm link. This repo already failed the policy gate on a pre-existing disallowed-url finding, unrelated to the new disclosure work. The link is legitimate - it is the published package a reader installs to use this server - so it is waived with a reason rather than removed. Scoped to that one npm org via pathPrefix, not the whole host, so an arbitrary third-party package link is still reported. Follow-up 5 of claude-workstation#1632.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ced9f66c-c50f-42f1-b612-55c456671cd0) |
Keeps main new purpose text and this branch policyWaivers/disclosureWaivers. Also corrects the description field this branch added: it claimed "18 tools", but main registers 24 (counted from the tool name registrations under src/tools/). Rather than re-pin a number that goes stale on every tool addition, the description now carries no count, matching main which states none anywhere.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b204a6db-405e-46c1-8d64-b7a4ac17c68f) |
| "policyWaivers": [ | ||
| { | ||
| "host": "www.npmjs.com", | ||
| "pathPrefix": "/package/@anthropic-ai", |
There was a problem hiding this comment.
Suggestion: pathPrefix covers every package under @anthropic-ai, so links to unrelated packages in that organization are silently exempted despite the waiver's narrower stated reason. [security]
Assessment: 🟠 Major · 🔁 Occurrence: Sometimes
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** .wave/repo.json
**Line:** 616:616
**Comment:**
*Security: `pathPrefix` covers every package under `@anthropic-ai`, so links to unrelated packages in that organization are silently exempted despite the waiver's narrower stated reason.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
User description
The new disclosure gate (wave-av/wave-context#157) flags an environment-variable name appearing near a state verb, because that pattern is how deployed configuration state leaks into published content.
Here it is a false positive, and worth recording rather than silencing: the README's troubleshooting section tells the reader to check their own environment. The variable belongs to the person installing the MCP server; it says nothing about any WAVE deployment.
Waivers are scoped to
ruleandmatchtogether, so this excuses exactly this identifier and cannot quietly cover a genuine deployed value added later. The finding stays printed on every run — only the exit code ignores it, so the exception cannot outlive its justification unnoticed.Unrelated, and not addressed here
This repo already fails the policy gate on a pre-existing
disallowed-urlfinding — an npm link outside the@wave-avscope — which predates this change and this PR does not touch. Flagging it so it is not mistaken for fallout from the new gate.Note
Low Risk
Config-only changes to waiver metadata and description; no application or security logic is modified.
Overview
Updates
.wave/repo.jsonso WAVE facts/disclosure gates can pass with documented exceptions.Adds a
descriptionstring for the MCP server package metadata. IntroducespolicyWaiversforwww.npmjs.com/package/@anthropic-aiso README links to the Claude Agent SDK install package are allowed without tripping disallowed-url rules. AddsdisclosureWaiversfor ruleconfig-statewith matchWAVE_API_KEY, documenting that troubleshooting’secho $WAVE_API_KEYrefers to the installer’s env, not deployed WAVE config.Reviewed by Cursor Bugbot for commit d8672f7. Configure here.
Note
Waive
WAVE_API_KEYdisclosure false positive in WAVE repo scan configAdds a
disclosureWaiversentry in repo.json to suppress a false positive triggered by theWAVE_API_KEYenvironment variable reference used in troubleshooting docs. Also adds apolicyWaiversentry for the@anthropic-ainpm package path and a project description string.Macroscope summarized d8672f7.
Summary by Sourcery
Enhancements:
CodeAnt-AI Description
Clarify the MCP server’s package description and document narrowly scoped policy exceptions
What Changed
@anthropic-aipackage link while continuing to flag unrelated npm linksImpact
✅ Clearer package information✅ Fewer false-positive policy failures✅ Unrelated links and disclosures remain reportable💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.