Skip to content

fix(ci): tomllib is not stdlib below Python 3.11, but the test matrix runs 3.9 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yakimoto wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

fix(ci): tomllib is not stdlib below Python 3.11, but the test matrix runs 3.9 #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/ga/ga_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
from pathlib import Path
from urllib.parse import quote, urlsplit

import tomllib
try: # tomllib is stdlib from 3.11; `tomli` is a dev dependency below that (see pyproject.toml).
import tomllib
except ModuleNotFoundError:
import tomli as tomllib

REPO_ROOT = Path(__file__).resolve().parent.parent.parent
USER_AGENT = "wave-ga-evidence-sdk-python/1.0"
Expand Down
10 changes: 7 additions & 3 deletions scripts/release/check_drift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@
2 a source was unreadable (network error, bad JSON, git/gh failure) --
an unreadable registry is NEVER treated as "in sync"

Stdlib + `git`/`gh` CLI only. No third-party imports so this runs identically
in CI and on a laptop with nothing but Python 3.11+ and the GitHub CLI.
Stdlib + `git`/`gh` CLI only (plus `tomli` as a dev dependency below Python 3.11, where `tomllib`
isn't stdlib yet) so this runs identically in CI and on a laptop with the GitHub CLI, across the
full `requires-python = ">=3.9"` matrix this package supports.
"""
from __future__ import annotations

Expand All @@ -40,7 +41,10 @@
import urllib.request
from pathlib import Path

import tomllib
try: # tomllib is stdlib from 3.11; `tomli` is a dev dependency below that (see pyproject.toml).
import tomllib
except ModuleNotFoundError:
import tomli as tomllib

PYPI_PROJECT = "wave-sdk"
GITHUB_REPO = "wave-av/sdk-python"
Expand Down
Loading