docs(readme): restore the #49 enrichment on top of main's grounded facts - #49
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_012353ed-1884-4749-92cb-bcf17471bc44) |
|
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 97 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Both sides regenerated .wave/repo.json and README.md from d807aac, so every line conflicts. Resolved NOT by hand-merging text but by rebuilding the SSOT from main and re-rendering the README through the content engine — a hand-resolved generated file is a file no generator would ever produce. main (PR #50, the currency rewrite) is authoritative for grounded facts and is preserved VERBATIM: every top-level key except the new `sections` is byte-identical to origin/main. This branch contributes only the enrichment, filtered for currency. See the following commit message for what was dropped and why.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_bf3e77d0-7515-40ba-b7e5-c59fcab5cc26) |
|
Follow-up note, recorded so the dropped content is recoverable rather than lost. Seven product examples were dropped from this PR because their capability is
They are not deleted — they remain at git show 63c67fc:.wave/repo.json | python3 -c "import sys,json;print(json.dumps(json.load(sys.stdin)['sections'],indent=2))"The condition for restoring any one of them is the same condition that made it wrong to ship now: its capability moving from Worth noting the engine cannot yet catch this class on its own: nothing today cross-checks a narrative |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_8a86abe1-e3ca-474d-9b36-423f750caaaf) |
CodeAnt Nitpicks5 code suggestions1. The new
|
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This PR only adds README content and corresponding documentation metadata, without changing SDK source, package exports, CI, or production behavior. Its blast radius is limited to published documentation and documentation/discovery rendering. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
User description
User description
Restores this branch's README enrichment on top of
main's grounded facts — and drops the parts of it that were no longer true.This PR had been
CONFLICTINGsince #50 landed. Both branches regenerated the same two files fromd807aac, so every line conflicted. Resolved by regeneration, not by hand-merge — a hand-resolved generated file is a file no generator would ever produce.The conflict was hiding a grounding regression
Reading the two sides rather than just the conflict markers:
mainis not merely newer here, it is more honest. PR #50 (the currency rewrite) replaced a uniformlibstatus with measured ones. This branch predates that and would have reverted it.63c67fc)main(e3864a7)liblib· 10planned· 2gaSo merging the old side in any form would have republished, on a public repo, runnable code examples for capabilities with no fleet backend.
What was dropped, and why
Seven product examples, each for a capability
mainmarksplannedor does not declare at all:These rendered as working
await wave.podcast…/await wave.phone…snippets. A reader would have pasted them and got nothing.plannedmeans the client surface exists and the backend does not.What was kept — and verified before keeping it
Six product examples, for the capabilities
mainmarkslib: Streams (Pipeline), Clips, Captions, Voice, Transcription, Editor. Every method they call was checked to exist insrc/onmainbefore the example was carried over:Twelve generic sections — Configuration, individual API imports, error handling, events, four troubleshooting entries, requirements, related packages. These assert no capability, so there is nothing to be stale about. Every npm link in Related packages was resolved (
@wave-av/adk,mcp-server,cli,create-app,workflow-sdkall200;wave-av/api-specis public).Three defects fixed on the way through
1. The API tables were mislabeled and incomplete. They were titled "All 34 APIs", listed 33 rows, and omitted 5 accessors —
client,drm,notifications,perception,realtime. Measured againstsrc/index.tsonmain: there are 38public readonlyaccessors (37 product modules +client) and 43 export subpaths.Retitled without the wrong count, given a Status column populated from the SSOT, and the four missing product modules added as an API modules — Platform table with descriptions quoted from each module's own header comment.
clientis the transport, not a product API, so it stays out.A legend section defines each label, so
sdk-surfacecannot be misread as shipping.2.
wave.voicewas described as "Text-to-speech, voice cloning" whilemain's own capability entry says voice-clone methods "exist as SDK client surface but are not backed by the wave-voice product yet." The table now says so.3. Requirements claimed "TypeScript 5.0+ (recommended 5.5+ for best subpath support)" with nothing behind either number. Replaced with what is checkable:
engines.nodeis>=18.0.0; TS 4.7+ is whatmoduleResolution: node16actually needs; this package builds on TypeScript 5.9.Receipts
main's grounded facts are preserved verbatim — not merged, not reconciled:The README is rendered by the engine, never hand-edited —
RepoFacts.parse→generateReadmefrom wave-context:The byte-identity check is the one that matters: it proves nobody touched the generated file after generation, which is exactly the failure mode a conflicted generated file invites.
Two engine findings this surfaced — neither is a blocker for this PR
generate --checkcannot verify a feature branch.discoverFactsSourcesresolves each repo's.wave/repo.jsonfrom its default ref viagit show— correct branch-truth discipline for a fleet scan, but it means an uncommitted or non-default-branch candidate is invisible to the CLI, which silently rendersmain's facts instead. I hit this first as a mystifying 101-line render. Verified here with a small branch-aware harness instead. Worth a--refflag.www.npmjs.comis not in the content-policy publish allowlist. The engine's ownlinks.npmfield emits an npmjs.com URL and its stage-⑥ scanner then flags it, somainalready trips this 3× today. This PR's Related packages table takes it from 3 → 15 findings — all one pre-existing class, every URL verified live. Filed separately against wave-context; not caused by this change.Verification caveat
CI has run on none of this. Actions are refusing every job org-wide on an account-level billing lock (
plan=free,locked=yes, re-confirmed today), so every number above is local measurement. Do not read a green-lookingmergeStateStatusas CI approval — during this outage GitHub creates no Actions check-run at all, so there is no red to see.This is public-facing copy on a public repo, so it wants a human read before it merges regardless of what CI eventually says.
Note
Low Risk
Documentation and SSOT metadata only; no runtime SDK or API behavior changes. Main risk is inaccurate public copy if statuses or examples drift from the codebase.
Overview
Adds a new
sectionsarray to.wave/repo.json(with JSON pretty-printing of existing metadata) so the README generator can emit a much larger public doc surface while keepingmain’s grounded capability facts unchanged.The generated
README.mdnow includes grouped API module tables (Core, Enterprise, Content & commerce, Specialized, Platform) with Access, Status (lib/planned/sdk-surface), and descriptions—including previously missing platform modules (drm,notifications,perception,realtime) and a legend for what each status means.wave.voiceis described as TTS viasynthesize()with clone APIs called out as SDK-only.Six product code examples are limited to capabilities marked
lib(pipeline, clips, captions, voice, transcribe, editor); examples for planned or unproven modules are omitted so readers are not shown runnable snippets against non-shipping backends. Additional generic sections cover configuration, subpath imports, errors, events, troubleshooting, requirements (Node 18+, TS 4.7+ / build on 5.9), and related npm packages.Reviewed by Cursor Bugbot for commit 4efba2e. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Expand the SDK README with grounded capability details and practical usage examples
What Changed
Impact
✅ Clearer distinction between live and unavailable capabilities✅ Faster SDK onboarding with ready-to-use examples✅ Fewer failed production calls to planned modules💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by Sourcery
Restore the README enrichment on top of main's grounded capability facts while ensuring public documentation reflects verified SDK and backend support.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Chores:
PR Type
Documentation
Description
Reconciles SDK docs with grounded SSOT, updating capability statuses
Adds gateway capabilities (wave-dispatch, gateway-agent-payments) with generic client access
Fixes voice module claims to reflect TTS-only implementation
Regenerates README with structured API tables and product examples
Diagram Walkthrough
File Walkthrough
repo.json
SDK capability status reconciliation and documentation updates.wave/repo.json
gateway-agent-payments)
README.md
Regenerated README with structured documentation and examplesREADME.md
voice, transcription, editor)