fix(deps): bump brace-expansion to 5.0.8 (supersedes #45)

[yakimoto]

User description

User description

Clears the brace-expansion HIGH (alert #3). Lockfile only — 4 lines.

brace-expansion  5.0.6 → 5.0.8    (dev scope, via eslint → @eslint/config-array → minimatch)

Supersedes #45, which bumps to 5.0.7 and clears nothing. Same fix as wave-av/mcp-server#67; the fleet-wide reasoning is in wave-av/claude-workstation#562.

Why #45 is a no-op — measured on this repo

There are two live brace-expansion advisories. The one on our alert is the older >= 3.0.0, < 5.0.7 (fix 5.0.7). The newer is GHSA-mh99-v99m-4gvg, range <= 5.0.7, patched only in 5.0.8 — so 5.0.7 lands inside it.

I pinned each version in the lockfile and ran the audit rather than reasoning about it:

brace-expansion	total	high	still flagged?
5.0.6 (main)	3	2	yes
5.0.7 (what #45 ships)	3	2	yes — range: <=5.0.7
5.0.8 (this PR)	2	1	no

Why 5.0.8 is safe here specifically

This is the part that doesn't generalise. minimatch@3.1.5 does const expand = require('brace-expansion') and calls the result as a function; every patched release exports an object. On a minimatch@3 tree the "fix" throws TypeError: expand is not a function at runtime while npm audit reports clean — that's claude-workstation#554, where it also passed 195/195 tests.

This repo has exactly one tree and it's minimatch@10.2.5, confirmed by reading the ref rather than a working copy:

$ git show origin/main:package-lock.json | …
node_modules/brace-expansion -> 5.0.6
node_modules/minimatch       -> 10.2.5

minimatch@10 uses named exports, so the object shape is what it already expects. Verified by driving the consumer, since npm audit never loads the module:

minimatch export kind: object | callable: true
brace expansion match  : true      # minimatch('file2.js','file{1,2}.js')
negative control       : false     # minimatch('file3.js','file{1,2}.js')
nested braces          : true      # minimatch('a/b/c.ts','a/{b,d}/{c,e}.ts')
brace-expansion export : object EXPANSION_MAX,EXPANSION_MAX_LENGTH,expand

That last line is the exact shape that breaks minimatch@3 — and brace expansion still resolves correctly through minimatch@10.

One thing in the diff worth naming

5.0.8 narrows its own engines from "18 || 20 || >=22" to "20 || >=22" — it drops Node 18. That does not propagate to consumers of @wave-av/sdk: brace-expansion is "dev": true here, reached only through eslint, so it never enters the published dependency graph and our own engines: >=18.0.0 is unaffected. CI runs Node 20 (lint.yml) and 22 (release.yml, publish.yml), both satisfied.

Verification

CI can't run — Actions are refusing every job org-wide on an account-level billing lock (plan=free, locked=yes, re-confirmed live today). All local, on Node 22.14.0:

npm run lint        → clean (--max-warnings 0)
npm run type-check  → clean
npm run build       → success
npm test            → 90 tests / 2 files, 0 failed

Measurement caveat: this workstation exports NODE_ENV=production, which makes npm audit inherit omit=dev and silently hide dev-scope entries — including this one. Every figure above was taken with NODE_ENV=development set explicitly. Anyone re-checking needs to do the same or they'll see a different, wrong number.

Separate finding, not fixed here

While measuring the baseline I found a HIGH that Dependabot is not reporting: postcss@8.5.15, dev-only via tsup/vite, vulnerable to GHSA-r28c-9q8g-f849 (<= 8.5.17, fix 8.5.18, published 2026-07-24). It's in the GitHub Advisory Database, but this repo's alert list has only brace-expansion and esbuild. Filed separately rather than folded into this diff.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.}

---

Note

Low Risk
Dev-only lockfile security bump with no runtime or published dependency impact; CI already runs Node 20/22.

Overview
Lockfile-only update bumps transitive dev dependency brace-expansion from 5.0.6 to 5.0.8 (via eslint → @eslint/config-array → minimatch) so the HIGH advisory GHSA-mh99-v99m-4gvg is cleared—5.0.7 would still fall inside the vulnerable <= 5.0.7 range.

Nothing in the published @wave-av/sdk graph changes; minimatch@10 already uses named exports compatible with the patched package shape. 5.0.8 also tightens engines to Node 20 || >=22 for that package only, which does not affect this package’s engines: >=18 because the dependency stays dev: true.

^{Reviewed by Cursor Bugbot for commit 0414df7. Bugbot is set up for automated code reviews on this repo. Configure here.}

---

Summary by cubic

Bumps brace-expansion to 5.0.8 in the lockfile to clear the HIGH advisory that a 5.0.7 bump wouldn't fully resolve. Dev-only, no runtime impact; the merge from main adds no other changes.

• Dependencies
  • 5.0.7 still sits inside the newer advisory (GHSA-mh99-v99m-4gvg, patched only in 5.0.8), confirmed by pinning each version and re-running npm audit.
  • Safe on this repo's minimatch@10 tree (named exports); the patched export shape breaks minimatch@3 consumers at runtime.
  • Upstream engines narrows to "20 || >=22"; dev-only, so the repo's >=18.0.0 is unaffected. CI runs Node 20/22; verified locally on Node 22 (CI was blocked by an org-wide billing lock). Re-checking npm audit requires NODE_ENV=development, since the shell default hides dev-scope entries.

^{Written for commit 0414df7. Summary will update on new commits.}

---

CodeAnt-AI Description

Update the development dependency to a security-fixed brace expansion release

What Changed

• Upgrades brace-expansion from 5.0.6 to 5.0.8 in the lockfile
• Removes the known high-severity vulnerability affecting the previous release
• The updated package now requires Node.js 20 or newer

Impact

✅ High-severity dependency alert resolved
✅ Safer development tooling
✅ Node.js 20+ compatibility made explicit

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

---

PR Type

Bug fix

---

Description

• Update clips.create() to use recording ID + time strings instead of nested source object

• Modify voice.synthesize() to return ArrayBuffer and use /v1/voice endpoint

• Add responseType support to WaveClient for binary responses

---

Diagram Walkthrough

flowchart LR
  A["Client.ts"] -- Adds responseType handling --> B["Request/Response"]
  C["Clips-types.ts"] -- Updates ClipSource shape --> D["Clip Contract"]
  E["Voice.ts"] -- Changes to ArrayBuffer return --> F["Audio Handling"]

Loading

File Walkthrough

	Relevant files

---

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5c9f06f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_20a4ede7-0bd3-41a7-9c78-b6122bc31efa)

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 65e53d20-b2b7-4352-a991-6633a8b53b35

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/brace-expansion-5-0-8

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch fix/brace-expansion-5-0-8

---

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

No reviewable files after applying ignore patterns.

[codeant-ai]

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Incremental review completed	0414df7	Sep 08, 2026 · 01:49	01:49
✅ Reviewed your PR	cffe2b3	Sep 06, 2026 · 20:06	20:07

[codeant-ai]

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_5ae521d6-140a-478c-96b4-803b074f12cc)

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change is confined to an ignored lockfile path and appears limited to a dev-only transitive dependency, so it should not alter published SDK behavior. Its stated purpose is to remediate a HIGH security advisory, making human review required under the review policy.

Not approved because:

• Credit balance exhausted. Approvability relies on correctness review in order to determine eligibility

^{Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_50b4feb4-f427-432d-9b3f-34b2df79f8ae)