Skip to content

chore(guard): sync vendored public-repo-guard to canonical - #60

Merged
yakimoto merged 2 commits into
mainfrom
chore/guard-canonical-sync
Sep 8, 2026
Merged

chore(guard): sync vendored public-repo-guard to canonical#60
yakimoto merged 2 commits into
mainfrom
chore/guard-canonical-sync

Conversation

@wave-av-release-bot

@wave-av-release-bot wave-av-release-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Syncs the vendored public-repo-guard trio to the canonical source in wave-foundation/scaffolder/public-repo-guard.

  • adds the internal-ip leak rule (Tailscale-CGNAT 100.64.0.0/10), lockstep with the pre-publish mirror gate
  • reconciles accumulated drift in the vendored copy

Each changed file is byte-for-byte identical to canonical (verified by git blob SHA). The repo's own Secrets + content policy gate re-scans this PR.

🤖 Generated with Claude Code


Open in Devin Review

Note

Update public-repo-guard workflow to use actions/checkout v7 without persisted credentials

Syncs public-repo-guard.yml to the canonical version. Upgrades actions/checkout from v5.0.1 to v7.0.0 and sets persist-credentials: false so the GITHUB_TOKEN is no longer stored in the repository's Git config after checkout.

Macroscope summarized a81a4bd.


Summary by cubic

Syncs the vendored public-repo-guard workflow to its canonical source and hardens the gitleaks scan.

  • Dependencies
    • Bump actions/checkout to v7.0.1.
    • Set persist-credentials: false so the job token isn't left in the working tree during the scan.

Written for commit fde7233. Summary will update on new commits.

Review in cubic

Summary by Sourcery

Sync the vendored public-repo-guard workflow with its canonical source and reduce credential exposure during repository scans.

Enhancements:

  • Synchronize the vendored public-repo-guard workflow with the canonical version and disable checkout credential persistence during scans.

CI:

  • Harden the public repository guard workflow by preventing the job token from being retained after checkout.

Chores:

  • Reconcile the vendored guard files with the canonical repository, including the latest pinned checkout action.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR author is in the excluded authors list.

@macroscopeapp

macroscopeapp Bot commented Aug 4, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Unable to check for correctness in a81a4bd. This PR updates the checkout action version and adds security hardening (persist-credentials: false) to a CI workflow. While the changes are low-risk, the modified file is owned by wave-av/core-team and the author (a bot) is not a designated owner, so review by the code owners is appropriate.

You can customize Macroscope's approvability policy. Learn more.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .github/workflows/public-repo-guard.yml Outdated
Comment on lines +45 to +53
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
# Checkout defaults to persisting the job token for later steps: since v6 it
# lives in a file under $RUNNER_TEMP referenced from .git/config, no longer in
# .git/config itself. It is still a live credential in the job, and this job
# downloads a third-party binary (gitleaks, below) and runs it over the whole
# tree. Nothing here pushes -- the scan is `--no-git` over the working tree --
# so no step needs authenticated Git; drop it. (zizmor: artipacked)
persist-credentials: false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Checkout action versions now diverge across workflows

This workflow moves to actions/checkout@9c091bb… (v7.0.0) while the rest of the repo pins other versions: v6.0.3 in .github/workflows/lint.yml:16 and .github/workflows/release.yml:41,77,131, and v4.3.1 in .github/workflows/_checks.yml:23,54,114. Also, persist-credentials: false is only applied here — the other workflows still persist the job token, so the artipacked hardening the comment describes is only partially rolled out. Worth confirming whether the intent was to standardize all workflows.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@yakimoto
yakimoto added this pull request to the merge queue Sep 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 8, 2026
@yakimoto
yakimoto enabled auto-merge September 8, 2026 01:18
…-sync

# Conflicts:
#	.github/workflows/public-repo-guard.yml
@codeant-ai

codeant-ai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Skipping PR review because a bot author is detected.

If you want to trigger CodeAnt AI, comment @codeant-ai review to trigger a manual review.

@yakimoto
yakimoto added this pull request to the merge queue Sep 8, 2026
Merged via the queue into main with commit 0c2c025 Sep 8, 2026
23 checks passed
@yakimoto
yakimoto deleted the chore/guard-canonical-sync branch September 8, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant