Skip to content

fix minikube test for minikube 1.39.0 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toelke merged 1 commit into from
Sep 5, 2026
Merged

fix minikube test for minikube 1.39.0 #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions hack/run-test-in-minikube.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ KUBERNETES_VERSION=${1:-v1.21}
trap "minikube delete" EXIT
}

eval $(minikube -p minikube docker-env)
docker build -f ./Dockerfile -t wave-local:local .
# Build directly inside the minikube node so this works with any container
# runtime (docker-env only supports the docker runtime, and minikube defaults
# to containerd since v1.39.0).
minikube -p minikube image build -f ./Dockerfile -t wave-local:local .

echo Installing wave...
if [ "$1" = "production" ]; then
Expand Down
Loading