Skip to content

Fix error when python 3.12 tests skips#117

Merged
joannatk merged 8 commits into
masterfrom
joannak/fix-python3.12-error-tests-skipped
Jul 16, 2025
Merged

Fix error when python 3.12 tests skips#117
joannatk merged 8 commits into
masterfrom
joannak/fix-python3.12-error-tests-skipped

Conversation

@joannatk

Copy link
Copy Markdown
Contributor

@joannatk joannatk requested a review from keep94 July 15, 2025 22:02

@keep94 keep94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Joanna. Thanks for the work. Just one minor comment.

Comment thread wavefront_sdk/client.py Outdated

@ustinov ustinov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add a comment as a duplicate, just use the literal forms

Comment thread wavefront_sdk/client.py Outdated
Comment thread wavefront_sdk/client.py Outdated
Comment thread wavefront_sdk/client.py Outdated
Comment thread wavefront_sdk/client.py Outdated
Comment thread wavefront_sdk/client.py Outdated
Comment thread wavefront_sdk/multi_clients.py Outdated
Comment thread wavefront_sdk/multi_clients.py Outdated
Comment thread wavefront_sdk/multi_clients.py Outdated
Comment thread wavefront_sdk/proxy.py Outdated
Comment thread wavefront_sdk/proxy.py Outdated
joannatk and others added 2 commits July 15, 2025 22:49
@joannatk

Copy link
Copy Markdown
Contributor Author

No need to add a comment as a duplicate, just use the literal forms

Thank you @ustinov ! All jobs pass with the literal form as well 💯

@joannatk joannatk requested a review from keep94 July 16, 2025 05:54

@keep94 keep94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joannatk joannatk merged commit e93338c into master Jul 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants