F/sync with upstream

[pieterbartsmit]

** DRAFT **

Purpose

Syncing sofar-develop with the upstream NOAA develop branch.

Some comments on merge

• I opted for a merge instead of a rebase; the rebase getting very tiresome. I don't think our git-history is particularly important.
• I manually resolved all the merge conflicts. Most are relatively straightforward.
• However- we have a bunch of custom code to handle output of a partitioned variable for energy < 0.1 Hz together with normal partitioned variables. It is hard to see if this was handled correctly.

Issues fixed

• WW3 IO code was refactored to no longer use (ancient) Fortran goto based exceptions. However, some of our custom code still used the old references producing a compile time error.

• We use W3_WCOR - a wind speed bias correction. This seems to be genuinely broken in the upstream ww3 codebase. There was a syntax error with a superfluous comma if this option was enabled. (update - known bug since March 26 apparently Syntax error in w3iogrmd.F90 with switch WCOR NOAA-EMC/WW3#1585)

• Fix merge artifacts and copy-paste bugs in custom second-partitioning code

  • PTHP0 was incorrectly reset to UNDEF instead of PTHP02 (w3iogomd.F90)
  • ASCII write for PNR2 was writing PNR instead (w3iogomd.F90)
  • Duplicate USE WMMDATMD/MDSUPA block from merge conflict (wminitmd.F90)
  • Typo in NetCDF standard name: 'diectional' -> 'directional' (w3ounfmetamd.F90)

• ** Fix PT12 partition loop regression introduced during upstream merge **
  The upstream refactor replaced explicit IFJ range checks with NOGE(IFI)-2,
  which correctly skips the last two scalar-per-point fields (PWST, PNR).
  However our extension of group 4 to 24 fields (PTMETH2 second partitioning
  scheme) caused PT12 (IFJ=23) to be incorrectly excluded from the partition
  loop, as it is now the second-to-last field despite being partitioned (0:1).
  Added explicit ELSE IF branch for IFJ=23 to restore correct behaviour.

Current Status.

• The code compiles on my local machine using gfortran on my local machine.
• I have not yet tested running the code.