Skip to content

Speaker similarity fix #84

Open
ftshijt wants to merge 4 commits into
wavlab-speech:mainfrom
ftshijt:main
Open

Speaker similarity fix #84
ftshijt wants to merge 4 commits into
wavlab-speech:mainfrom
ftshijt:main

Conversation

@ftshijt

@ftshijt ftshijt commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add warnings when speaker similarity, singer identity similarity, and EMO2VEC emotion similarity receive audio below their embedding model target sample rates.
  • Keep existing resampling behavior intact while making potentially unreliable upsampled embedding scores visible to users.
  • Add lightweight tests that assert the warning behavior without requiring model downloads.

Motivation

Issue #83 notes that speaker embedding similarity can be misleading for audio sampled below 16 kHz, especially with the default RawNet3-style path. The same concern applies to similar learned embedding comparisons that silently upsample lower-rate audio before scoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant