Open
Conversation
Owner
|
Thanks for proposing these changes, they look good! However, I did receive some requests from users asking for per-document customization. Instead of blocklisting document ids, what if we store an ExtensionData object for each document the user wants to individually customize? This approach adds some additional complexity and user-experience decisions, but I think this is a much more robust encompassing solution that also encapsulates your proposed features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed functionality for allowing the plugin to be disabled on specific documents.
Main changes:
Known bugs and improvements:
Related to #119