Closed
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Collaborator
|
I'm going to reject this. The code in general seems like a mess, would take too much effort to bring it up to acceptable quality, and I honestly don't even want to spend my time reviewing it properly after taking a quick look. It's full-on slop. I want to avoid adding AI generated code. Nobody knows how it works, it only results in increased maintenance burden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
This adds a screen-focus flow to WayVR so a specific desktop screen can be pulled into a focused VR view and then restored back to its normal state. It also includes the focused-screen tuning/config plumbing and the Hyprland helper scripts I’ve been using locally to exercise the feature against the active monitor/window.
The basic idea is that you can make a global keybind to "focus" a screen. Focusing a screen moves it directly in front of you and automatically rotates/translates it based on your head movement to make it easier to work with. It really helps with text in particular.
You can also have it focus a cropped part of a screen, which is nice if you just want to focus e.g. a single window, though that takes some extra work user-side. One of the scripts does this for you if you use Hyprland like me though =)
How it works
wayvrctladds two entry points for this:screen-focus-toggle <SCREEN_NAME>screen-focus-at [--crop-x ... --crop-y ... --crop-w ... --crop-h ... --refresh-only] <SCREEN_NAME> <TARGET_X> <TARGET_Y>Those commands send a screen-focus IPC request into WayVR. The runtime then:
The
screen-focus-at --refresh-onlypath is there so an external helper can keep updating the focused crop/target in place without toggling the focus mode off and back on each time.How to test it
Manual CLI testing:
wayvrctl screen-focus-toggle <SCREEN_NAME>wayvrctl screen-focus-at <SCREEN_NAME> 0.5 0.5wayvrctl screen-focus-at --crop-x 0.1 --crop-y 0.1 --crop-w 0.6 --crop-h 0.6 <SCREEN_NAME> 0.5 0.5Hyprland-based testing:
scripts/wayvr-hypr-screen-toggle.shtoggles focus for the active monitorscripts/wayvr-hypr-local.sh / scripts/wayvr-hypr-helper-local.shfocus the active monitor, derive crop/target from the active window, and keep it refreshed as the active window changesscripts/test-focus.shis a quick sanity check for the exposed CLI flowValidation run on this branch:
cargo fmt --allcargo check -p wayvr-ipccargo check -p wayvrctlcargo check -p wayvrcargo test -p wayvr-ipccargo test -p wayvrctlcargo test -p wayvrcargo run -q -p wayvrctl -- screen-focus-at --help