Add sonic_api_test.c to tests/Makefile's TEST_SRC - #72
Open
austek wants to merge 1 commit into
Open
Conversation
tests.h/runtests.c declare and call sonicTestStreamCreation, sonicTestParameters, sonicTestFlush, and sonicTestSimpleProcessing -- all defined in tests/sonic_api_test.c -- but tests/Makefile's TEST_SRC was never updated to include it, so `cd tests && make runtests` fails to link with undefined references to all four. Reproduced on a clean checkout of master.
austek
added a commit
to ZirekHQ/espeak-ng-sonic
that referenced
this pull request
Aug 23, 2026
tests.h/runtests.c declare and call sonicTestStreamCreation, sonicTestParameters, sonicTestFlush, and sonicTestSimpleProcessing -- all defined in tests/sonic_api_test.c -- but tests/Makefile's TEST_SRC was never updated to include it, so `cd tests && make runtests` fails to link with undefined references to all four. Same gap ported (and independently confirmed) in waywardgeek/sonic#72; also fixed directly in the still-open PR espeak-ng#2 ("Sync 5 commits from waywardgeek/sonic"), which is what actually introduces this mismatch on that branch -- this commit applies the same fix to develop directly, since develop already has that content merged in independently of whether/when espeak-ng#2 lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests.h/runtests.cdeclare and callsonicTestStreamCreation,sonicTestParameters,sonicTestFlush, andsonicTestSimpleProcessing— all defined intests/sonic_api_test.c— buttests/Makefile'sTEST_SRCwas never updated to include it, socd tests && make runtestsfails to link with undefined references to all four.Reproduced on a clean checkout of
master:```
$ cd tests && make runtests
...
undefined reference to
sonicTestStreamCreation' undefined reference tosonicTestParameters'undefined reference to
sonicTestFlush' undefined reference tosonicTestSimpleProcessing'```
(The root
Makefile's ownsonic_unit_testtarget already includestests/sonic_api_test.ccorrectly — this is specifically abouttests/Makefile's separate, standalone target.)Test plan
cd tests && make runtests && ./runtests— now builds and passes (was a link failure before)