Fix style#6
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on stylistic/formatting cleanups across the SvelteKit site, supporting scripts, and documentation, with a few small behavior-adjacent tweaks (e.g., keyed {#each} blocks and preload attributes on links).
Changes:
- Reformat/clean up markup, CSS, scripts, and markdown files for consistency.
- Add keyed
{#each}blocks and adjust some ARIA/linting configuration around rendering. - Update ESLint configuration and README formatting/checklists.
Reviewed changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/sponsors/+page.svelte | Adds keyed {#each} blocks; adjusts sponsor card list semantics. |
| src/routes/newsletter/[id]/+page.svelte | Adds an ESLint disable for {@html} usage. |
| src/routes/newsletter/[id]/+page.js | Adds JSDoc typedef and type assertion around article lookup. |
| src/routes/members/current/+page.svelte | Removes unused sample data and simplifies driver filtering comment/code. |
| src/routes/donate/+page.svelte | Removes unused mailing address constant. |
| src/routes/cars/[id]/+page.svelte | Removes CSS for a commented-out section and tweaks link preloading. |
| src/routes/about/+page.svelte | Adds data-sveltekit-preload-data to an internal link. |
| src/routes/+page.svelte | Adds data-sveltekit-preload-data to an internal link. |
| src/routes/+layout.svelte | Removes unused dropdown state/helpers (dropdown markup is commented out). |
| src/lib/newsletters/articles/shop-night-fabrication.md | Minor formatting/whitespace adjustment. |
| src/lib/newsletters/articles/regional-competition-recap.md | Minor spacing adjustments around lists. |
| scripts/generate-articles.mjs | Pure formatting/indentation changes. |
| scripts/debug-md.mjs | Formatting plus improved error logging on missing deps. |
| index.html | HTML/CSS formatting and self-closing tags normalization. |
| google38ad0fa849da7d01.html | Whitespace normalization. |
| eslint.config.js | Adds a disabled Svelte lint rule and trailing commas. |
| README.md | Formatting cleanup and checklist normalization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div class="sponsor-grid" role="list"> | ||
| {#each tier.sponsors as sponsor} | ||
| {#each tier.sponsors as sponsor (sponsor.name)} | ||
| <a | ||
| class="sponsor-card" |
There was a problem hiding this comment.
The container uses role="list", but the immediate children are anchors without role="listitem". This breaks the ARIA list pattern and can reduce screen-reader semantics. Either restore role="listitem" on each sponsor card (or wrap them in elements with role="listitem"), or remove role="list" and use a semantic <ul><li> structure instead.
| const articleEntry = /** @type {Article} */ ( | ||
| allEntries.find((e) => e.type === 'article' && e.id === id) | ||
| ); |
There was a problem hiding this comment.
allEntries.find(...) can return undefined, but the JSDoc assertion forces the type to Article, which hides that possibility from type checking and can mask real issues. Prefer typing this as Article | undefined (or do the assertion only after the not-found check) so the types match runtime behavior.
| const articleEntry = /** @type {Article} */ ( | |
| allEntries.find((e) => e.type === 'article' && e.id === id) | |
| ); | |
| /** @type {Article | undefined} */ | |
| const articleEntry = allEntries.find((e) => e.type === 'article' && e.id === id); |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Make some style changes in the code; no changes were actually made to the site.