Skip to content

Add test for user count and page count for deleted wikis metrics #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosalieper wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test for user count and page count for deleted wikis metrics #1035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions tests/Metrics/WikiMetricsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,4 +363,32 @@ public function testSavesEntityCountsCorrectly($expectedItemCount, $expectedProp
'entity_schema_count' => $expectedEntitySchemaCount, // redirects should be ignored
]);
}

public function testSavesCorrectUserCountAndPagesForDeletedWikis() {
$this->markTestSkipped(); // https://phabricator.wikimedia.org/T402189 should be resolved for this test to pass.
$wiki = Wiki::factory()->create([
'domain' => 'somedomain.wikibase.cloud',
]);
$wikiDb = WikiDb::first();
$wikiDb->update(['wiki_id' => $wiki->id]);
Http::fake([
'somedomain.wikibase.cloud' => Http::response([
'query' => [
'statistics' => [
'users' => 5,
'pages' => 10,
],
],
], 200),
]);
$wiki->delete();
(new WikiMetrics)->saveMetrics($wiki);

$this->assertDatabaseHas('wiki_daily_metrics', [
'wiki_id' => $wiki->id,
'pages' => 10,
'total_user_count' => 5,
'is_deleted' => 1,
]);
}
}
Loading