logging: adjust service name by environment #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dati18
requested changes
Dec 17, 2025
| $payload[ 'severity' ] = $level; | ||
| $payload[ 'serviceContext' ] = [ | ||
| 'service' => 'WBaaS MediaWiki', | ||
| 'service' => 'WBaaS MediaWiki' . $envString, |
Contributor
There was a problem hiding this comment.
should we separate these? Add 'environment' => $envString instead of merging it with service
Contributor
Author
There was a problem hiding this comment.
excellent question! That would be cleaner, yes, and I think I will just add it to the context array too.
The reason I combined it with the service name here is so that it will show up separately in Google Cloud Console:
Co-authored-by: Dat WMDE <dat.nguyen@wikimedia.de>
dati18
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T412862