Skip to content

Andrea's TicTacToe#209

Open
andicodetrf wants to merge 2 commits into
wdi-sg:masterfrom
andicodetrf:master
Open

Andrea's TicTacToe#209
andicodetrf wants to merge 2 commits into
wdi-sg:masterfrom
andicodetrf:master

Conversation

@andicodetrf
Copy link
Copy Markdown

Deliverable Submission

Please describe your comfort and completeness levels before submitting.

Comfort Level (1-5): finished 1st version

Completeness Level (1-5): 5 for 1st version

How many hours did you spend on this assignment? 1.5 hours

What part did you spend the most time on? creating a grid in html and css-ing it

Does the assignment run without errors? think so

If the assignment has errors, what are they?

Describe one part of the code or choose one line you would improve upon.

What would you improve?

What did you think of this deliverable? Any other comments?

@andicodetrf
Copy link
Copy Markdown
Author

will work on 2nd version

@andicodetrf
Copy link
Copy Markdown
Author

Comfort Level (1-5): finished 2nd version; 2 out of 5 for CSS

Completeness Level (1-5): 1.5 for 2nd version

How many hours did you spend on this assignment? 1.5 hours

What part did you spend the most time on? controlling the CSS part

Does the assignment run without errors? functionality is the same as ver1. aesthetically, error on layout

If the assignment has errors, what are they? span size changes when player inputs X or O.

Describe one part of the code or choose one line you would improve upon. CSS part; not sure what am i doing just trial and error for span..

What would you improve? fix span size regardless if there is any text within. or perhaps i should've used div instead of span and display as inline.

What did you think of this deliverable? Any other comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant