Skip to content

Sometimes convert result will be \uXXXX. - #1

Open
soulteary wants to merge 3 commits into
we11adam:masterfrom
soulteary:master
Open

Sometimes convert result will be \uXXXX.#1
soulteary wants to merge 3 commits into
we11adam:masterfrom
soulteary:master

Conversation

@soulteary

Copy link
Copy Markdown

Hi, there're more and more template engine, some template engine may cause the result contain "\uxxxx", if someone use the gulp-native2ascii around the template engine render action, it doesn't work possibility.

eg:

.pipe(N2A({reverse: false}))
.pipe(TemplateEngine.render())
.pipe(N2A({reverse: true}))

:D

@we11adam

Copy link
Copy Markdown
Owner

Hello, can you please include some test cases in your pull request so that I can merge the changes altogether? Thanks.

@soulteary

Copy link
Copy Markdown
Author

@adamme you're welcome, i'll add some test cases later.

thank you for response.

@soulteary

Copy link
Copy Markdown
Author

@adamme sorry for late, review plz, :D

Comment thread index.js

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're some template engine will render "\u1234" -> "\u1234", so it seems to restore the string one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants