Sometimes convert result will be \uXXXX. - #1
Open
soulteary wants to merge 3 commits into
Open
Conversation
Owner
|
Hello, can you please include some test cases in your pull request so that I can merge the changes altogether? Thanks. |
Author
|
@adamme you're welcome, i'll add some test cases later. thank you for response. |
Author
|
@adamme sorry for late, review plz, :D |
Author
There was a problem hiding this comment.
There're some template engine will render "\u1234" -> "\u1234", so it seems to restore the string one by one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, there're more and more template engine, some template engine may cause the result contain "\uxxxx", if someone use the
gulp-native2asciiaround the template engine render action, it doesn't work possibility.eg:
:D