Open
Conversation
…ed flexibility; change Vectorizer class access modifier to public; update project file with packaging details and metadata.
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 60.9%
Weaviate.Client.Analyzers - 91.1%
|
- Updated enum serialization attributes from System.Runtime.Serialization.EnumMember to System.Text.Json.Serialization.JsonStringEnumMemberName for consistency and improved JSON handling. - Introduced EmptyStringEnumConverter to handle empty strings and nulls for enum properties. - Enhanced JSON serialization options in WeaviateRestClient to improve error handling during deserialization. - Adjusted various model classes to utilize the new serialization attributes and converters.
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 8 35 2 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
 Failed |
Vulnerabilities | 2 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Pattern Undefined | .../Schema/openapi.json | View in code |
|
Pattern Undefined | .../Schema/openapi.json | View in code |
|
Pattern Undefined | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Maximum Length Undefined (v3) | .../Schema/openapi.json | View in code |
|
Maximum Length Undefined (v3) | .../Schema/openapi.json | View in code |
|
Maximum Length Undefined (v3) | .../Schema/openapi.json | View in code |
|
Default Response Undefined On Operations (v3) | .../Schema/openapi.json | View in code |
|
Default Response Undefined On Operations (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Format (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Format (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Format (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Format (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Maximum (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Maximum (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Maximum (v3) | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
| ... | ... | ... | ... |
☢️ The following Vulnerabilities (CVEs) have been detected
| PACKAGE | FILE | CVE ID | INSTALLED VERSION | FIXED VERSION | ||
|---|---|---|---|---|---|---|
|
System.Text.Json | ...s/packages.lock.json | CVE-2024-30105 | 8.0.0 | 8.0.4 | View in code |
|
System.Text.Json | ...s/packages.lock.json | CVE-2024-43485 | 8.0.0 | 8.0.5, 6.0.10 | View in code |
Add StopSequences property to Providers and update generative.proto
…s for improved clarity and accuracy
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 8 35 2 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Array Without Maximum Number of Items (v3) | .../Schema/openapi.json | View in code |
|
Pattern Undefined | .../Schema/openapi.json | View in code |
|
Pattern Undefined | .../Schema/openapi.json | View in code |
|
Pattern Undefined | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Format (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Format (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Format (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Format (v3) | .../Schema/openapi.json | View in code |
|
Response on operations that should have a body has undefined schema | .../Schema/openapi.json | View in code |
|
Response on operations that should have a body has undefined schema | .../Schema/openapi.json | View in code |
|
Default Response Undefined On Operations (v3) | .../Schema/openapi.json | View in code |
|
Default Response Undefined On Operations (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Minimum (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Minimum (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Minimum (v3) | .../Schema/openapi.json | View in code |
|
Numeric Schema Without Minimum (v3) | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
| ... | ... | ... | ... |
Support new backup restore statuses
BuildBatchProperties used reflection (type.GetProperties()) to iterate over C# properties, which returned nothing for ExpandoObject/IDictionary inputs. This caused batch inserts via the managed client to store empty properties in Weaviate. Added early-return path for IDictionary<string, object?> that iterates dictionary entries directly, matching the existing pattern in BuildDataTransferObject for the REST path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ce type handling in Filter
…nce internal testing capabilities
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 6 10 8 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Array Items Has No Type (v3) | .../Schema/openapi.json | View in code |
|
Array Items Has No Type (v3) | .../Schema/openapi.json | View in code |
|
Array Items Has No Type (v3) | .../Schema/openapi.json | View in code |
|
Array Items Has No Type (v3) | .../Schema/openapi.json | View in code |
|
JSON Object Schema Without Properties | .../Schema/openapi.json | View in code |
|
JSON Object Schema Without Properties | .../Schema/openapi.json | View in code |
|
Response Code Missing (v3) | .../Schema/openapi.json | View in code |
|
Response Code Missing (v3) | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Response on operations that should have a body has undefined schema | .../Schema/openapi.json | View in code |
|
Response on operations that should have a body has undefined schema | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
Type Has Invalid Keyword | .../Schema/openapi.json | View in code |
Adds `BaseURL` property to `Reranker.Cohere` and updates `RerankerConfigFactory.Cohere()` to accept `baseURL` parameter, matching the pattern already used by `Reranker.Nvidia` and aligning with the Python client implementation. Closes #230 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…racing (#93) - Replace all hardcoded LoggerFactory.Create(b => b.AddConsole()) with NullLoggerFactory.Instance (silent by default, zero console output) - Add WithLoggerFactory(ILoggerFactory) and UseRequestLogging(LogLevel) to WeaviateClientBuilder for opt-in structured logging - Add HttpLoggingHandler (DelegatingHandler): logs HTTP method, URI, status code, elapsed time; redacts Authorization header values - Add LoggingInterceptor (gRPC Interceptor): logs gRPC method, status, elapsed time; logs Warning on RpcException - Thread ILoggerFactory through ClientConfiguration, WeaviateOptions, DefaultTokenServiceFactory, and DI WeaviateClientFactory - Set GrpcChannelOptions.LoggerFactory to enable built-in channel logging - Add unit tests for HttpLoggingHandler and LoggingInterceptor (TDD) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Implements DELETE /schema/{className}/properties/{propertyName}/index/{indexName} for dropping inverted indices from collection properties.
Changes:
- Add PropertyIndexType enum (Filterable, Searchable, RangeFilters)
- Add CollectionConfigClient.DeletePropertyIndex() method
- Update OpenAPI spec and regenerate DTOs with IndexName enum
- Add version guard requiring Weaviate 1.36+
- Update minimum supported version to 1.32.0
- Fix CI configuration for Weaviate 1.35+
- Add comprehensive CI diagnostics
- Standardize Docker registry to cr.weaviate.io
- Fix OBJECTS_TTL_DELETE_SCHEDULE cron spec
In Weaviate v1.36.0, the backup restore behavior changed. When attempting to restore a backup over an existing collection, the restore endpoint now: - Returns HTTP 200 OK initially - The async operation completes with status FAILED - Error message in response: 'class name ... already exists' Updated the test to check for the failed status and error message rather than expecting an exception, which aligns with how async backup operations report failures through status polling.
…ion (#293) The Weaviate gRPC protocol only supports fp32 (SingleFp32/MultiFp32), but ToByteString(this Vector) was serializing the backing data using its native byte width (8 bytes for double, 8 bytes for long, etc.). When a user provided a double[] vector of dimension 1536, the server received 12288 bytes labelled as SingleFp32 and interpreted them as 3072 floats — doubling the dimension with garbled NaN values. The fix converts all non-float numeric types to float32 before byte serialisation in both ToByteString() and ToMultiDimensionalByteString(). The single REST insert path was unaffected (JSON serialisation handles doubles natively); only the gRPC batch path and vector-search path were buggy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…doubling fix: Convert non-float vectors to float32 before gRPC byte serialization (#293)
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 0 8 2 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Response on operations that should have a body has undefined schema | .../Schema/openapi.json | View in code |
|
Response on operations that should have a body has undefined schema | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Response Code Missing (v3) | .../Schema/openapi.json | View in code |
|
Response Code Missing (v3) | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
Type Has Invalid Keyword | .../Schema/openapi.json | View in code |
feat: Add BaseURL to Cohere Reranker config
feat: Add support for dropping property inverted indices
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 0 13 21 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Invalid Format | .../Schema/openapi.json | View in code |
|
Response Code Missing (v3) | .../Schema/openapi.json | View in code |
|
Response Code Missing (v3) | .../Schema/openapi.json | View in code |
|
Response Code Missing (v3) | .../Schema/openapi.json | View in code |
|
Response Code Missing (v3) | .../Schema/openapi.json | View in code |
|
Type Has Invalid Keyword | .../Schema/openapi.json | View in code |
|
Type Has Invalid Keyword | .../Schema/openapi.json | View in code |
|
Type Has Invalid Keyword | .../Schema/openapi.json | View in code |
|
Path Is Ambiguous | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
Template Path With No Corresponding Path Parameter | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
|
JSON '$ref' alongside other properties | .../Schema/openapi.json | View in code |
| ... | ... | ... | ... |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Vectorizer methods to utilize generic type parameters for better flexibility and change the class access modifier to public.
Introduce cancellation token support in various configuration methods and clarify parameter names in NearText and NearVector methods.
Update project file with packaging details and metadata.