Add reconfigure options for Dynamic index#406
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
There was a problem hiding this comment.
Pull request overview
This pull request adds reconfiguration support for dynamic vector indexes and fixes a typo in the type name VectorIndexConfigDymamicUpdate (corrected to VectorIndexConfigDynamicUpdate). The PR extends the reconfigure API to support dynamic indexes, following the same pattern as the existing configure.dynamic function.
Changes:
- Added
reconfigure.dynamicfunction to enable runtime reconfiguration of dynamic vector indexes - Fixed typo in type name from
VectorIndexConfigDymamicUpdatetoVectorIndexConfigDynamicUpdatewith backward-compatible deprecated alias - Refactored existing reconfigure functions (flat, hfresh, hnsw) to use typed update objects instead of inline parameters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/collections/configure/types/vectorIndex.ts | Fixed typo in type name, added deprecated alias for backward compatibility, and updated type union and mapping references |
| src/collections/configure/vectorIndex.ts | Added VectorIndexConfigDynamicUpdate import, refactored reconfigure.flat/hfresh/hnsw signatures, and implemented new reconfigure.dynamic function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Weroiko
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
reconfigure.dynamicand fix some typos.