Split ann_benchmark.go into focused files#99
Open
rlmanrique wants to merge 2 commits into
Open
Conversation
The original file was ~1274 lines handling schema creation, compression,
multi-tenancy, async indexing, query execution, and CLI wiring all in one
place. Split into four files with clear single responsibilities:
- ann_schema.go — schema CRUD, updateEf, tenant management, deletes
- ann_ingest.go — CompressionType/Batch types, createClient, writeChunk,
waitReady, enableCompression
- ann_query.go — parseEfValues, runQueries, shouldStopRunQueries,
benchmarkANN/Duration, median/sampledResults
- ann_benchmark.go — ResultsJSONBenchmark, uuidFromInt/intFromUUID,
cobra command + flag registration only
All existing unit tests and integration tests continue to pass.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 3 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following SAST misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Avoid Using `math/rand` for Cryptographic Operations in Go | ...ker/cmd/ann_query.go | View in code |
|
Directory Permissions Are Set to Overly Permissive Values | ...ker/cmd/ann_query.go | View in code |
|
Overly Permissive File Permissions Set in Application | ...ker/cmd/ann_query.go | View in code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original file was ~1274 lines handling schema creation, compression, multi-tenancy, async indexing, query execution, and CLI wiring all in one place. Split into four files with clear single responsibilities:
benchmarkANN/Duration, median/sampledResults
cobra command + flag registration only
All existing unit tests and integration tests continue to pass.