WebVTT: Split VTTRegion lines test into two#17400
Open
gkatsev wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
WebVTT: Split VTTRegion lines test into two#17400gkatsev wants to merge 1 commit intoweb-platform-tests:masterfrom
gkatsev wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
This makes the current lines.html test page only test for compliance of negative values and values in the int range. This is because all implementations do not currently implement this field as an unsigned long. The second file, lines-long.html check for whether this field supports unsigned long values.
silviapfeiffer
approved these changes
Jun 21, 2019
silviapfeiffer
approved these changes
Jun 21, 2019
Contributor
Author
|
If w3c/webvtt#461 lands, we can remove the lines-long.html test. |
silviapfeiffer
approved these changes
Jun 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the current lines.html test page only test for compliance of
negative values and values in the int range. This is because all
implementations do not currently implement this field as an unsigned
long.
The second file, lines-long.html check for whether this field supports
unsigned long values.