Skip to content

[selectors4] Add new tests for :focus-within as universal selector#5249

Merged
frivoal merged 2 commits into
web-platform-tests:masterfrom
mrego:more-focus-within-tests
Apr 5, 2017
Merged

[selectors4] Add new tests for :focus-within as universal selector#5249
frivoal merged 2 commits into
web-platform-tests:masterfrom
mrego:more-focus-within-tests

Conversation

@mrego

@mrego mrego commented Mar 29, 2017 •
edited by gsnedders
Loading

Copy link
Copy Markdown
Member

This just adds 2 new simple tests that were useful for my implementation on Blink.

Please @frivoal could you take a look? Thanks!

This change is Reviewable

@wpt-pr-bot

wpt-pr-bot commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

Notifying @frivoal, @plinss, and @tabatkins. (Learn how reviewing works.)

@ghost

ghost commented Mar 29, 2017 •
edited by ghost
Loading

Copy link
Copy Markdown

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 8267890
Using browser at version BuildID 20170404100210; SourceStamp b5d8b27a753725c1de41ffae2e338798f3b5cacd
Starting 10 test iterations
All results were stable

All results

2 tests ran
/css/selectors4/focus-within-007.html
Subtest Results Messages
PASS
/css/selectors4/focus-within-008.html
Subtest Results Messages
PASS

@ghost

ghost commented Mar 29, 2017 •
edited by ghost
Loading

Copy link
Copy Markdown

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 8267890
Using browser at version 59.0.3053.3 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran
/css/selectors4/focus-within-007.html
Subtest Results Messages
FAIL
/css/selectors4/focus-within-008.html
Subtest Results Messages
FAIL

@frivoal

frivoal commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

Looks good to me. Do you want to drop the interact flag first (as in #5370) before I merge?

@ghost

ghost commented Apr 5, 2017 •
edited by ghost
Loading

Copy link
Copy Markdown

These tests are now available on w3c-test.org

@mrego

mrego commented Apr 5, 2017

Copy link
Copy Markdown
Member Author

Removed the interact flag here too.

frivoal
frivoal reviewed Apr 5, 2017
View reviewed changes
Comment thread css/selectors4/focus-within-008.html Outdated
@@ -1,10 +1,9 @@
<!DOCTYPE html>
<meta charset="utf-8">

@frivoal frivoal Apr 5, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove the <meta charset="urf-8"> intentionally? That looks like an accident. Revert?

@mrego mrego Apr 5, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all, removed the wrong line, sorry.

@mrego mrego force-pushed the more-focus-within-tests branch from 29b9929 to 32cac9a Compare April 5, 2017 16:00
@frivoal

frivoal commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

Looks good, merging.

@frivoal frivoal merged commit af6f835 into web-platform-tests:master Apr 5, 2017
@mrego mrego deleted the more-focus-within-tests branch April 6, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frivoal frivoal frivoal left review comments

Assignees

No one assigned

Labels

selectors wg-css

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrego @wpt-pr-bot @frivoal @gsnedders