-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Remove "interact" flags for tests that can be run automatically #5370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> | ||
|
|
||
| <html xmlns="http://www.w3.org/1999/xhtml"> | ||
|
|
||
| <head> | ||
|
|
||
| <title>CSS Reftest Reference</title> | ||
| <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> | ||
|
|
||
| <style type="text/css"><![CDATA[ | ||
| body | ||
| { | ||
| background-color: green; | ||
| border: blue solid; | ||
| color: white; | ||
| margin: 1em; | ||
| padding: 2em; | ||
| } | ||
|
|
||
| div | ||
| { | ||
| background: green url("support/square-purple.png") no-repeat center center; | ||
| border: lime solid; | ||
| padding: 3em; | ||
| } | ||
| ]]></style> | ||
|
|
||
| </head> | ||
|
|
||
| <body> | ||
|
|
||
| <div>In the middle of the bright blue rectangle, there should be a purple tile.</div> | ||
|
|
||
| </body> | ||
| </html> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> | ||
| <html xmlns="http://www.w3.org/1999/xhtml"> | ||
| <head> | ||
| <title>CSS Test: Background propagation on <body> and <html> - propagated position</title> | ||
| <link rel="author" title="Ian Hickson" href="mailto:ian@hixie.ch"/> | ||
| <link rel="alternate" href="http://www.hixie.ch/tests/adhoc/css/background/09.html" type="text/html"/> | ||
| <link rel="help" href="http://www.w3.org/TR/CSS21/colors.html#background"/> | ||
| <link rel="match" href="background-root-012b-ref.xht" /> | ||
|
|
||
| <meta name="flags" content="image"/> | ||
| <style type="text/css"><![CDATA[ | ||
| body { border: solid lime; background: green url(support/square-purple.png) no-repeat 50% 50%; color: white; } | ||
| html { border: solid blue; background: transparent; color: yellow; } | ||
| :link, :visited { color: inherit; background: transparent; } | ||
| * { margin: 1em; padding: 1em; } | ||
| ]]></style> | ||
|
|
||
| </head> | ||
| <body> | ||
| <p> In the middle of the bright blue rectangle, there | ||
| should be a purple tile. | ||
|
|
||
| </p></body> | ||
| </html> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> | ||
|
|
||
| <html xmlns="http://www.w3.org/1999/xhtml"> | ||
|
|
||
| <head> | ||
|
|
||
| <title>CSS Reftest Reference</title> | ||
|
|
||
| <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> | ||
|
|
||
| <style type="text/css"><![CDATA[ | ||
| body | ||
| { | ||
| background-color: navy; | ||
| border: blue solid; | ||
| color: white; | ||
| margin: 1em 5%; | ||
| padding: 1em; | ||
| } | ||
|
|
||
| div | ||
| { | ||
| background: green url("support/square-purple.png") no-repeat center; | ||
| border: lime solid; | ||
| margin: 1em 30% 1em 5%; | ||
| padding: 1em; | ||
| } | ||
|
|
||
| div > div | ||
| { | ||
| border: none; | ||
| margin: 1em 5%; | ||
| padding: 1em; | ||
| } | ||
| ]]></style> | ||
|
|
||
| </head> | ||
|
|
||
| <body> | ||
|
|
||
| <div> | ||
| <div>In the middle of this green box with the bright green border, there should be a purple tile.</div> | ||
| </div> | ||
|
|
||
| </body> | ||
| </html> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> | ||
| <html xmlns="http://www.w3.org/1999/xhtml"> | ||
| <head> | ||
| <title>CSS Test: Background propagation on <body> and <html> - non-propagated position</title> | ||
| <link rel="author" title="Ian Hickson" href="mailto:ian@hixie.ch"/> | ||
| <link rel="alternate" href="http://www.hixie.ch/tests/adhoc/css/background/10.html" type="text/html"/> | ||
| <link rel="help" href="http://www.w3.org/TR/CSS21/colors.html#background"/> | ||
| <link rel="match" href="background-root-013b-ref.xht" /> | ||
| <meta name="flags" content="image"/> | ||
|
|
||
| <style type="text/css"><![CDATA[ | ||
| body { border: solid lime; background: green url(support/square-purple.png) no-repeat 50% 50%; color: white; } | ||
| html { border: solid blue; background: navy; color: yellow; } | ||
| :link, :visited { color: inherit; background: transparent; } | ||
| * { margin: 1em 5%; padding: 1em; } | ||
| body { margin-right: 30%; } | ||
| ]]></style> | ||
|
|
||
| </head> | ||
| <body> | ||
| <p> In the middle of this green box with the bright green border, there | ||
| should be a purple tile.</p> | ||
|
|
||
|
|
||
| </body> | ||
| </html> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> | ||
|
|
||
| <html xmlns="http://www.w3.org/1999/xhtml"> | ||
|
|
||
| <head> | ||
|
|
||
| <title>CSS Reftest Reference</title> | ||
| <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> | ||
|
|
||
| <style type="text/css"><![CDATA[ | ||
| body | ||
| { | ||
| background-color: navy; | ||
| border: blue solid; | ||
| color: white; | ||
| margin: 1em; | ||
| padding: 2em; | ||
| } | ||
|
|
||
| div | ||
| { | ||
| background: green url("support/square-purple.png") no-repeat fixed center; | ||
| border: lime solid; | ||
| padding: 3em; | ||
| } | ||
| ]]></style> | ||
|
|
||
| </head> | ||
|
|
||
| <body> | ||
|
|
||
| <div>In the exact middle of this page, there should be a purple tile. The tile must only be visible when the green box overlaps the tile; it must be hidden when overlapping the blue background.</div> | ||
|
|
||
| </body> | ||
| </html> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> | ||
| <html xmlns="http://www.w3.org/1999/xhtml"> | ||
| <head> | ||
| <title>CSS Test: Background propagation on <body> and <html> - non-propagated attached position</title> | ||
| <link rel="author" title="Ian Hickson" href="mailto:ian@hixie.ch"/> | ||
| <link rel="alternate" href="http://www.hixie.ch/tests/adhoc/css/background/11.html" type="text/html"/> | ||
| <link rel="help" href="http://www.w3.org/TR/CSS21/colors.html#background"/> | ||
| <link rel="match" href="background-root-014b-ref.xht" /> | ||
| <meta name="flags" content="image"/> | ||
| <style type="text/css"><![CDATA[ | ||
| body { border: solid lime; background: green url(support/square-purple.png) fixed no-repeat 50% 50%; color: white; } | ||
| html { border: solid blue; background: navy; color: yellow; } | ||
| :link, :visited { color: inherit; background: transparent; } | ||
| * { margin: 1em; padding: 1em; } | ||
| ]]></style> | ||
|
|
||
| </head> | ||
| <body> | ||
| <p>In the exact middle of this page, there should be a purple tile. | ||
| The tile must only be visible when the green box overlaps the tile; | ||
| it must be hidden when overlapping the blue background.</p> | ||
|
|
||
| </body> | ||
| </html> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <html class="reftest-wait"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Regions: named flow content has contentEditable attribute set</title> | ||
| <link rel="author" title="Mihai Balan" href="mailto:mibalan@adobe.com"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#the-flow-into-property"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#flow-from"> | ||
| <link rel="help" href="http://www.w3.org/TR/html5/editing.html#contenteditable"> | ||
| <meta name="flags" content="dom interact"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (not my spec) Similarly to the comment on focus-within-001: As we switch to js required instead of js merely being a helper, it would be good to add class="reftest-wait" on the root, and remove it once js has run, so that we make sure that the ref comparison is done at the right time, and that if js fails to run for some reason, we detect it as a test that failed to run rather than a failure to implement focus-within correctly.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's nothing async in there, so it should be fine just taking the screenshot after the load event fires. |
||
| <meta name="flags" content="dom"> | ||
| <meta name="assert" content="Test checks that setting the contentEditable attribute on | ||
| elements that get flowed in a region does not affect their rendering in the regions. Also, | ||
| such elements should be editable just as they are outside of the region."> | ||
|
|
@@ -53,6 +53,7 @@ | |
| <script type="text/javascript" src="support/helpers.js"></script> | ||
| <script type="text/javascript"> | ||
| insertText("#marked", "foobar bazquux"); | ||
| document.documentElement.classList.remove('reftest-wait'); | ||
| </script> | ||
| </body> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <html class="reftest-wait"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Regions: named flow content has a child with contentEditable attribute set</title> | ||
| <link rel="author" title="Mihai Balan" href="mailto:mibalan@adobe.com"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#the-flow-into-property"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#flow-from"> | ||
| <link rel="help" href="http://www.w3.org/TR/html5/editing.html#contenteditable"> | ||
| <meta name="flags" content="dom interact"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as css-regions-1/contentEditable/contentEditable-001.html |
||
| <meta name="flags" content="dom"> | ||
| <meta name="assert" content="Test checks that setting the contentEditable attribute on | ||
| elements that get flowed in a region does not affect their rendering in the regions. Also, | ||
| such elements should be editable just as they are outside of the region, even if they are | ||
|
|
@@ -68,6 +68,7 @@ | |
| <script type="text/javascript"> | ||
| insertText("#marked-inactive", "foobar bazquux"); | ||
| insertText("#marked-active", "foobar bazquux"); | ||
| document.documentElement.classList.remove('reftest-wait'); | ||
| </script> | ||
| </body> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <html class="reftest-wait"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Regions: element has contentEditable attribute set and both it and a child of it are | ||
|
|
@@ -8,7 +8,7 @@ | |
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#the-flow-into-property"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#flow-from"> | ||
| <link rel="help" href="http://www.w3.org/TR/html5/editing.html#contenteditable"> | ||
| <meta name="flags" content="dom interact"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as css-regions-1/contentEditable/contentEditable-001.html |
||
| <meta name="flags" content="dom"> | ||
| <meta name="assert" content="Test checks that flowing both and element and one of its | ||
| children in a region, when said element has the contentEditable attribute set does not | ||
| affect their rendering in the regions and the ability to edit it."> | ||
|
|
@@ -75,6 +75,7 @@ | |
| <script type="text/javascript"> | ||
| insertText("#marked-parent", "foobar bazquux"); | ||
| insertText("#marked-child", "foobar bazquux"); | ||
| document.documentElement.classList.remove('reftest-wait'); | ||
| </script> | ||
| </body> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <html class="reftest-wait"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Regions: named flow content has contentEditable attribute set and is fragmented</title> | ||
| <link rel="author" title="Mihai Balan" href="mailto:mibalan@adobe.com"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#the-flow-into-property"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#flow-from"> | ||
| <link rel="help" href="http://www.w3.org/TR/html5/editing.html#contenteditable"> | ||
| <meta name="flags" content="dom interact"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as css-regions-1/contentEditable/contentEditable-001.html |
||
| <meta name="flags" content="dom"> | ||
| <meta name="assert" content="Test checks that setting the contentEditable attribute on | ||
| elements that get flowed in a region does not affect their rendering and the ability to edit | ||
| them even when they get fragmented in multiple regions."> | ||
|
|
@@ -73,6 +73,7 @@ | |
| <script type="text/javascript"> | ||
| insertText("#marked-one", "foobar bazquux"); | ||
| insertText("#marked-two", "foobar bazquux"); | ||
| document.documentElement.classList.remove('reftest-wait'); | ||
| </script> | ||
| </body> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <html class="reftest-wait"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Regions: named flow content has contentEditable attribute set and is flowed in an | ||
|
|
@@ -8,7 +8,7 @@ | |
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#the-flow-into-property"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#flow-from"> | ||
| <link rel="help" href="http://www.w3.org/TR/html5/editing.html#contenteditable"> | ||
| <meta name="flags" content="dom interact"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as css-regions-1/contentEditable/contentEditable-001.html |
||
| <meta name="flags" content="dom"> | ||
| <meta name="assert" content="Test checks that setting the contentEditable attribute on | ||
| elements that get flowed in a region does not affect their rendering in the regions. Also, | ||
| if the region uses height:auto, the size of the region should change as the content flowed | ||
|
|
@@ -73,6 +73,7 @@ | |
| <script type="text/javascript"> | ||
| insertText("#marked-one", "foobar bazquux"); | ||
| insertText("#marked-two", "foobar bazquux"); | ||
| document.documentElement.classList.remove('reftest-wait'); | ||
| </script> | ||
| </body> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <html class="reftest-wait"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CSS Regions: named flow content has contentEditable attribute set and children of it get | ||
|
|
@@ -8,7 +8,7 @@ | |
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#the-flow-into-property"> | ||
| <link rel="help" href="http://www.w3.org/TR/css3-regions/#flow-from"> | ||
| <link rel="help" href="http://www.w3.org/TR/html5/editing.html#contenteditable"> | ||
| <meta name="flags" content="dom interact"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as css-regions-1/contentEditable/contentEditable-001.html |
||
| <meta name="flags" content="dom"> | ||
| <meta name="assert" content="Test checks that setting the contentEditable attribute on | ||
| an element does not interfere with its children being dinamically flowed into a region."> | ||
| <link rel="match" href="reference/contentEditable-007-ref.html"> | ||
|
|
@@ -82,6 +82,7 @@ | |
| insertText("#marked-outside", "foobar bazquux"); | ||
| insertText("#marked-inside", "foobar bazquux"); | ||
| insertText("#marked-inside-new", "foobar bazquux"); | ||
| document.documentElement.classList.remove('reftest-wait'); | ||
| }) | ||
| </script> | ||
| </body> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
<meta name="flags" content="" />rather than deleting the line. See the comment on focus-within-001 for rationale.