Fix insertAdjacentHTML and outerHTML using wrong customElementRegistry#59458
Open
chromium-wpt-export-bot wants to merge 1 commit into
Open
Fix insertAdjacentHTML and outerHTML using wrong customElementRegistry#59458chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7789715
branch
from
895472f to
6f6fa07
Compare
wpt-pr-bot
approved these changes
Apr 24, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
insertAdjacentHTML with 'beforebegin'/'afterend' and the outerHTML setter were incorrectly passing the calling element's customElementRegistry to the HTML fragment parser, instead of the containing scope's (parent's) registry. For 'beforebegin'/'afterend', new nodes become siblings under the parent, so they should inherit the parent's registry. The code already correctly resolved context_node to the parent, but the registry was still taken from 'this' element. The fix derives the registry from context_node: if it's an Element, use its customElementRegistry(); otherwise fall back to the tree scope's registry (handles ShadowRoot and DocumentFragment parents). Bug: 489973914 Change-Id: I31658ed4c95039a92ee883ee57782e8947c206fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789715 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Jayson Chen <jaysonchen@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1620451}
jonathan-j-lee
force-pushed
the
chromium-export-cl-7789715
branch
from
6f6fa07 to
2ecb128
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insertAdjacentHTML with 'beforebegin'/'afterend' and the outerHTML setter
were incorrectly passing the calling element's customElementRegistry to
the HTML fragment parser, instead of the containing scope's (parent's)
registry.
For 'beforebegin'/'afterend', new nodes become siblings under the
parent, so they should inherit the parent's registry. The code already
correctly resolved context_node to the parent, but the registry was
still taken from 'this' element.
The fix derives the registry from context_node: if it's an Element, use
its customElementRegistry(); otherwise fall back to the tree scope's
registry (handles ShadowRoot and DocumentFragment parents).
Bug: 489973914
Change-Id: I31658ed4c95039a92ee883ee57782e8947c206fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789715
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Jayson Chen <jaysonchen@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1620451}