Implement text-decoration-skip-spaces, part 2#59786
Merged
Merged
Conversation
This CL implements the paint part of text-decoration-skip-spaces. https://drafts.csswg.org/css-text-decor-4/#text-decoration-skip-spaces-property Decoration trimming is done entirely at paint time: leading/trailing spaces are handled by narrowing decoration_box, and interior spaces are clipped via context.ClipOut(). Bug: 40862777 Change-Id: I30a43a200e2f032399ed0996366aaad4c67db6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7792866 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1628459}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7792866
branch
from
a79beb2 to
d5bea02
Compare
wpt-pr-bot
approved these changes
May 11, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL implements the paint part of text-decoration-skip-spaces.
https://drafts.csswg.org/css-text-decor-4/#text-decoration-skip-spaces-property
Decoration trimming is done entirely at paint time: leading/trailing
spaces are handled by narrowing decoration_box, and interior spaces are
clipped via context.ClipOut().
Bug: 40862777
Change-Id: I30a43a200e2f032399ed0996366aaad4c67db6cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7792866
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1628459}