[gap-decorations] Fix cross gap offset for middle lines in fragmented flex#59795
Draft
chromium-wpt-export-bot wants to merge 1 commit into
Draft
[gap-decorations] Fix cross gap offset for middle lines in fragmented flex#59795chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
… flex Use cross_start (the fragment-aware offset) instead of flex_line.cross_axis_offset when computing the cross intersection offset for middle flex lines. The latter doesn't account for fragmentation offsets, causing misplaced gap decorations in fragmented flex containers Bug: 481074852 Change-Id: I99dc49a512f5743733b9f589eb57ec9c6c9e41bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cross_start (the fragment-aware offset) instead of
flex_line.cross_axis_offset when computing the cross intersection offset
for middle flex lines. The latter doesn't account for fragmentation
offsets, causing misplaced gap decorations in fragmented flex containers
Bug: 481074852
Change-Id: I99dc49a512f5743733b9f589eb57ec9c6c9e41bd
Reviewed-on: https://chromium-review.googlesource.com/7808504
WPT-Export-Revision: 14823df5c23c9fa27e24967bebabb19729b5f70c