[Gecko Bug 2010717] Implement alignment-baseline: alphabetic/ideographic/central/mathematical/hanging.#59796
Closed
moz-wptsync-bot wants to merge 1 commit into
Closed
[Gecko Bug 2010717] Implement alignment-baseline: alphabetic/ideographic/central/mathematical/hanging.#59796moz-wptsync-bot wants to merge 1 commit into
moz-wptsync-bot wants to merge 1 commit into
Conversation
…ical/hanging. Also adds WPT reftests to validate alignment behavior in horizontal and vertical writing modes with the different `alignment-baseline` values. Additionally: - The `alignment-baseline: middle` tests have failing expectations. This is because the existing implementation does not match the css-inline-3 definition (which the new WPTs follow). See Bug 2030203. - The WidthTest-Regular.otf support font was updated to remove its unusual ideographic-under baseline value, which affected its synthesized central baseline. With the new support for `alignment-baseline: central`, this broke a number of `text-combine-upright-compression-*` WPT reftests. The non-centered baseline values were removed from this test using FontForge, so that the synthesized central baseline matched the expectation of the test references. Differential Revision: https://phabricator.services.mozilla.com/D292136 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2010717 gecko-commit: c1fe9407a01153ffbe5d56a4fb877ead6da0bfba gecko-commit-git: 482c9f881b6a4e972cbe6a905e5bd9a1d17ceefb gecko-reviewers: layout-reviewers, firefox-style-system-reviewers, dshin
wpt-pr-bot
approved these changes
May 11, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds WPT reftests to validate alignment behavior in horizontal and vertical
writing modes with the different
alignment-baselinevalues. Additionally:The
alignment-baseline: middletests have failing expectations. This isbecause the existing implementation does not match the css-inline-3 definition
(which the new WPTs follow). See Bug 2030203.
The WidthTest-Regular.otf support font was updated to remove its unusual
ideographic-under baseline value, which affected its synthesized central
baseline. With the new support for
alignment-baseline: central, this broke anumber of
text-combine-upright-compression-*WPT reftests. The non-centeredbaseline values were removed from this test using FontForge, so that the
synthesized central baseline matched the expectation of the test references.
Differential Revision: https://phabricator.services.mozilla.com/D292136
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2010717
gecko-commit: c1fe9407a01153ffbe5d56a4fb877ead6da0bfba
gecko-commit-git: 482c9f881b6a4e972cbe6a905e5bd9a1d17ceefb
gecko-reviewers: layout-reviewers, firefox-style-system-reviewers, dshin