[A11y] Prevent recursive AX subtree removal cycles#59799
Merged
Conversation
RemoveSubtree() can walk both DOM children and cached AX children. With an aria-owns cycle that also crosses DOM containment, cached AX traversal can re-enter an AXObject already being removed and recurse until stack overflow. Track AXIDs currently active in RemoveSubtree() and return if removal reaches one again. This keeps subtree removal from following cyclic AX ownership paths indefinitely. Bug: 446989592 Change-Id: Iec4932a209989ce29f5e70cc04e6a420908e9afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7791334 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/main@{#1628753}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7791334
branch
from
77e8356 to
aebc42d
Compare
wpt-pr-bot
approved these changes
May 11, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveSubtree() can walk both DOM children and cached AX children. With
an aria-owns cycle that also crosses DOM containment, cached AX
traversal can re-enter an AXObject already being removed and recurse
until stack overflow.
Track AXIDs currently active in RemoveSubtree() and return if removal
reaches one again. This keeps subtree removal from following cyclic AX
ownership paths indefinitely.
Bug: 446989592
Change-Id: Iec4932a209989ce29f5e70cc04e6a420908e9afd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7791334
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1628753}