fix(windows): normalize WGC video timestamps#552
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughMFEncoder adds timestamp normalization to normalize incoming sample timestamps to an encoder-local timeline. New helper methods track the first sample time and normalize timestamps before writing frames and extending the prior frame. The build manifest is updated to reflect the compiled changes. ChangesMFEncoder Timestamp Normalization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
wgc-capture.exeand update the helper manifest entry for the rebuilt binary/source fingerprint.Why
After PR #551, static WGC captures no longer collapsed at the stream level, but direct packaged helper smoke still showed
ffprobe format.durationaround 544,000 seconds while the video stream duration was only about 6 seconds. That is noisy metadata and could confuse consumers that read container duration instead of stream duration.Validation
npm run build:windows-capturewgc-capture: passedformat.duration=6.533300, video streamduration=6.533300format.duration=6.533300, system WAVduration=6.523979, timing sidecar written withstartDelayMs=0npx tsc --noEmitnpm test -- src/hooks/useScreenRecorder.test.ts src/lib/mediaTiming.test.ts electron/ipc/export/native-video.test.ts(126 passed)npx biome check electron/native/bin/win32-x64/helpers-manifest.jsongit diff --checkKnown Baseline Check
npm test -- electron/ipc/recording/diagnostics.test.tsfails on currentorigin/mainand on this branch with the same pre-existing expectation mismatch: the helper returnsrecording.system.wavin addition to the embedded video audio and mic companion. I did not mix that unrelated test/behavior fix into this timestamp PR.Summary by CodeRabbit