Skip to content

Patriboz/redo sword grunt - #3694

Closed
patriboz wants to merge 6 commits into
tcm-redo-sword-gruntfrom
patriboz/redo-sword-grunt
Closed

Patriboz/redo sword grunt#3694
patriboz wants to merge 6 commits into
tcm-redo-sword-gruntfrom
patriboz/redo-sword-grunt

Conversation

@patriboz

@patriboz patriboz commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

Base PR: #3674

With this PR I intend to fix the issues mentioned in the base PR above.

This includes:

  • refactoring animations-baker.js,
  • refactoring character-sfx.js,
  • removing metaverse_components/use.js

Comment thread character-sfx.js Outdated
const walkRunAnimationName = (() => {
if (isNarutoRun) {
return 'naruto run.fbx';
return "naruto run.fbx";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My linter went crazy on the quotes. Will fix that with the next commit.

@patriboz
patriboz marked this pull request as ready for review September 8, 2022 16:12
@patriboz
patriboz requested a review from avaer September 8, 2022 16:30

@avaer avaer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine.

@avaer avaer closed this Sep 17, 2022
@avaer

avaer commented Sep 17, 2022

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants