chore: update package.json & package-lock.json#440
Closed
ersachin3112 wants to merge 2 commits intowebpack:masterfrom
Closed
chore: update package.json & package-lock.json#440ersachin3112 wants to merge 2 commits intowebpack:masterfrom
ersachin3112 wants to merge 2 commits intowebpack:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 95.68% 95.43% -0.26%
==========================================
Files 3 3
Lines 371 372 +1
Branches 119 118 -1
==========================================
Hits 355 355
- Misses 15 16 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Lint is failing |
Member
|
I am working on this here - #439, there is a regression on |
|
|
||
| Type: | ||
|
|
||
| <!-- eslint-skip --> |
Member
There was a problem hiding this comment.
Don't use skip, fix types, we need to fix it in other repos too
Contributor
Author
There was a problem hiding this comment.
i used this for README.md file only because eslint is reading it as JS file resulting code-block lint fail.
Member
|
Fixed by #439 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
update package.json & package-lock.json
Breaking Changes
No
Additional Info
No