feat: integrate zizmor#1849
Open
trueberryless wants to merge 2 commits into
Open
Conversation
commit: |
Member
|
Thanks for the PR. Overall I feel like it's a bit much for this particular repo. We're not using Not sure we want The The thing that we should definitely push though is the moved/scoped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
zizmorto the project. Zizmor is a static GitHub Actions analyser that aims to make actions more secure with best practices and security advisories.To integrate Zizmor, I ran the CLI locally to analyse the current GitHub Actions and applied some fixes. I also decided to add newlines between each step for more readable workflow files. Zizmor passes locally completely:
I also added a new
zizmoraction which makes sure that workflow edits never regress and the security recommendations are maintained in the future. This workflow should also pass in this PR already 🤞Additionally, I decided to move the
markdown-lint-check.jsonout of the.github/workflowsfolder in the parent dir:.githubbecause I think that inside the.github/workflowsfolder there should mainly only be actual GitHub Action files. But I didn't move thescriptsandsnapshotsbecause they are not as distracting as the one.jsonfile was in the middle of the.ymlfiles.