Open
Conversation
Based on Alex Osborne's excellent start in the WARC specifications repository: http://iipc.github.io/warc-specifications/guidelines/cdx-non-get-requests/ Todo: - Come up with better/more accurate name, since it doesn't only affect POST requests - Write AMF section
Shrinks99
reviewed
Apr 5, 2024
Contributor
Shrinks99
left a comment
Shrinks99
left a comment
There was a problem hiding this comment.
No comments on spec content (not qualified), a few copy edits :)
Looks good from here!
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Collaborator
|
It would be great to get this published as a starting point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141
This PR adds a new specification for Request Body Canonicalization (sometimes also referred to as POST canonicalization), which describes new consistent behavior between pywb and warcio.js, with fixes to bring them in line to the standard in webrecorder/pywb#893 and webrecorder/warcio.js#68.
The spec is based heavily on the draft specification written by @ato and published in the WARC Specifications repository at http://iipc.github.io/warc-specifications/guidelines/cdx-non-get-requests/.
At this point the description of how AMF bodies are transformed simply points to the pywb codebase and points out that the feature is only in pwyb and is considered experimental.
Perhaps optimistically, I set the publication date to next Monday :)